Remove obsolete v1 tests (part 1)#487
Conversation
|
I'm not sure what coveralls means here - I can't see any significant coverage difference:
Running locally is also different:
|
|
The miss on commonBindings.js line 62 is totally expected - it is NGSI-v1 specific code. |
| it('should add a transport to the registered devices', function (done) { | ||
| const getDeviceOptions = { | ||
| url: 'http://localhost:' + config.iota.server.port + '/iot/devices/MQTT_UNPROVISIONED', | ||
| method: 'GET', | ||
| headers: { | ||
| 'fiware-service': 'TestService', | ||
| 'fiware-servicepath': '/testingPath' | ||
| } | ||
| }; | ||
|
|
||
| request(getOptions, function (error, response, body) { | ||
| request(getDeviceOptions, function (error, response, body) { | ||
| should.not.exist(error); | ||
|
|
||
| const parsedBody = JSON.parse(body); | ||
|
|
||
| response.statusCode.should.equal(200); | ||
| should.exist(parsedBody.transport); | ||
| parsedBody.transport.should.equal('HTTP'); | ||
| done(); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
This it section is not present on NGSI-v2 test here
|
Im going to summarize all changes needed to have the same coverage (or, at least, the same "scenarios") on V1 and V2 for an effective v1 removal from IoTA Node Lib codebase. Not all of them apply to this specific PR (since still remains some tests on V1 folder)
|
PR #499 adds missing NGSIv2 tests. I think this PR is now ready to be merged. @jason-fox I understand that after this PR an equivalent of PR telefonicaid/iotagent-json#561 ("Switch tests to NGSI-v2") will be done, right? |
fgalan
left a comment
fgalan
left a comment
There was a problem hiding this comment.
LGTM
Passing the ball to @mapedraza for final LGTM and merge
I have discussing this with @mapedraza and it seems that the ""Switch test to NGSI-v2" PR is not needed in this case. However, it seems some NGSI-v1 tests are pending from removal. PR #505 should fix that. |
3 participants
In order to merge telefonicaid/iotagent-node-lib#995 I want to get the unit-tests running without relying on NGSI-v1. This PR just deletes tests which are already duplicated in the NGSI-v2 test suite. Any drop in coverage should be within acceptable limits
This is the ultralight equivalent of iotagent-json/553. Supersedes #478