Conversation
|
Maybe this PR shoud use In addition, please sync this PR with master. Some test has been fixed recently in master branch (PR #476 ) |
|
Similar to telefonicaid/iotagent-json#553 (comment), we should consider if the coverage drop (2.3% this case) is "within acceptable limits". |
|
This one is now 0.8%, but I can't see any obvious gap. Looking at the coverage report the drop is due to code that needs to be deleted such as this NGSI-v1 constant or AMPQ disconnection which is due to there now only being 1 connection test not two. I think this is all that can be done for this pass. |
|
As can be seen from the equivalent here some of the drop is indeed due to the AMQP connection reducing the number of tests and potentially not needing a |
|
Just to know... why this PR has been closed? Maybe due to the force push? |
|
Probably. I've rebased, amended the scope to delete only and re-raised as #487 |
In order to merge telefonicaid/iotagent-node-lib#995 I want to get the unit-tests running without relying on NGSI-v1. This PR just deletes tests which are already duplicated in the NGSI-v2 test suite. Any drop in coverage should be within acceptable limits.