Skip to content

Fix NGSIv2 under-covered scenarios#506

Merged
fgalan merged 1 commit intomasterfrom
task/fix-ngsiv2-tests
Jul 14, 2021
Merged

Fix NGSIv2 under-covered scenarios#506
fgalan merged 1 commit intomasterfrom
task/fix-ngsiv2-tests

Conversation

@mapedraza
Copy link
Copy Markdown
Collaborator

This PR is intended to restore some differences between tests that were deleted in NGSIv1 and were not present in NGSv2

  • mqttBinding-test.js

@mapedraza mapedraza marked this pull request as draft July 14, 2021 13:08
@mapedraza
Copy link
Copy Markdown
Collaborator Author

Pending to review the rest of the tests deleted in #487

@mapedraza
Copy link
Copy Markdown
Collaborator Author

After reviewing the .js test files in #487, no more gaps were detected. Now this PR is ready for review.

@mapedraza mapedraza marked this pull request as ready for review July 14, 2021 14:00
Copy link
Copy Markdown
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 4856b9b into master Jul 14, 2021
@fgalan fgalan deleted the task/fix-ngsiv2-tests branch July 14, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants