Add ZK testing capabilities by ilanolkies · Pull Request #17436 · smartcontractkit/chainlink

ilanolkies · 2025-04-24T14:44:35Z

Tests deploying Link Token on Anvil ZK Sync using the new Go bindings. This PR is part of #17047

Requires

Bumping:

github.com/smartcontractkit/chainlink-deployments-framework v0.1.1
github.com/smartcontractkit/chainlink-testing-framework/framework v0.7.9

Follows smartcontractkit/chainlink#17436

ilanolkies · 2025-05-13T15:18:17Z

 	github.com/smartcontractkit/chainlink-ccip/chains/solana v0.0.0-20250512193142-11507db18550
 	github.com/smartcontractkit/chainlink-common v0.7.1-0.20250509155341-2b5a5170a351
-	github.com/smartcontractkit/chainlink-deployments-framework v0.0.15-0.20250508081139-ee24199564bd
+	github.com/smartcontractkit/chainlink-deployments-framework v0.1.1-0.20250513145550-8e845f1272ca


Requires versioning

github-actions · 2025-05-13T15:27:54Z

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

This keeps it even with develop

The error was changed in CTF

ilanolkies · 2025-05-13T22:35:44Z

+	commonchangeset.DeployLinkTokenTest(t, memory.MemoryEnvironmentConfig{
+		Chains:    1,
+		SolChains: 1,
+	})


This change is due to test refactoring

This reverts commit 518b139.

This reverts commit 6b7e899.

cl-sonarqube-production · 2025-05-15T02:25:51Z

Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

github-actions · 2025-05-15T02:58:34Z

Flakeguard Summary

Ran new or updated tests between develop and 2b1648e (zk-testing).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

9 Results

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Package	Package Panicked?	Avg Duration	Code Owners
TestBillingWithoutMcms	50%	false	false	false	2	1	1	github.com/smartcontractkit/chainlink/deployment/ccip/changeset/solana	true	3m5.89s	@smartcontractkit/solana-tooling, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestPoolLookupTableWithoutMcms	0%	true	true	false	1	0	1	github.com/smartcontractkit/chainlink/deployment/ccip/changeset/solana	true	0s	@smartcontractkit/solana-tooling, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestTokenAdminRegistryWithoutMcms	66.6667%	false	false	true	3	2	1	github.com/smartcontractkit/chainlink/deployment/ccip/changeset/solana	true	2m11.37s	@smartcontractkit/solana-tooling, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestTransferCCIPFromMCMSWithTimelockSolana	66.6667%	false	false	false	3	2	1	github.com/smartcontractkit/chainlink/deployment/ccip/changeset/solana	true	2m32.756666666s	@smartcontractkit/solana-tooling, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestDeployLinkTokenZk	33.3333%	false	false	false	3	1	2	github.com/smartcontractkit/chainlink/deployment/common/changeset	false	22.116666666s	@smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestDeployMCMSWithTimelockV2	66.6667%	false	false	false	3	2	1	github.com/smartcontractkit/chainlink/deployment/common/changeset	false	45.646666666s	@smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestMCMSSignFireDrillChangeset	0%	false	false	false	3	0	3	github.com/smartcontractkit/chainlink/deployment/common/changeset	false	55.633333333s	@smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestSetConfigMCMSV2EVM/MCMS_disabled	0%	false	false	true	3	0	3	github.com/smartcontractkit/chainlink/deployment/common/changeset	false	1m0.03s	@smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestSetConfigMCMSV2Solana/MCMS_disabled	0%	false	false	true	3	0	3	github.com/smartcontractkit/chainlink/deployment/common/changeset	false	51.1s	@smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Ilan added 4 commits April 24, 2025 11:29

Add ZK testing capabilities

03565b2

Port Link Token changeset

6ce5ee0

Avoid lint

2228762

go mod tidy

02277ec

AnieeG reviewed Apr 24, 2025

View reviewed changes

Ilan added 6 commits April 24, 2025 13:03

Remove unnecesary 0

41fcf67

Add comment

37efa67

Add timeout

219fbb8

Validate test pks length

d1ec77c

Use test context

d104932

-Add comment to nolint

36c87fc

AnieeG previously approved these changes Apr 24, 2025

View reviewed changes

makramkd reviewed Apr 28, 2025

View reviewed changes

Merge branch 'develop' into zk-testing + use 'ZkSyncVM' suffix

c8c0eda

ilanolkies commented May 12, 2025

View reviewed changes

Comment thread deployment/go.mod Outdated

kylesmartin previously approved these changes May 12, 2025

View reviewed changes

ilanolkies pushed a commit to smartcontractkit/chainlink-deployments-framework that referenced this pull request May 13, 2025

Add ZK env

9acd26e

Follows smartcontractkit/chainlink#17436

ilanolkies mentioned this pull request May 13, 2025

Add ZK env smartcontractkit/chainlink-deployments-framework#79

Merged

github-merge-queue Bot pushed a commit to smartcontractkit/chainlink-deployments-framework that referenced this pull request May 13, 2025

Add ZK env (#79)

8e845f1

Follows smartcontractkit/chainlink#17436

Ilan added 2 commits May 13, 2025 12:13

Bump testing-framework and deployments-framework

34130b9

Merge branch 'develop' into zk-testing

9ded44e

ilanolkies commented May 13, 2025

View reviewed changes

Tidy all go mods

f846395

Ilan added 6 commits May 13, 2025 12:45

Fix solana link test

f4990e8

Add normal chain to solana test

ab11ce1

This keeps it even with develop

Merge branch 'develop' into zk-testing

e2838cc

Merge branch 'develop' into zk-testing

3de6941

Go mod tidy again

370a61f

Tidy another one

09034c1

Fix solana test

6b7e899

The error was changed in CTF

ilanolkies commented May 13, 2025

View reviewed changes

Comment thread deployment/common/changeset/solana/fund_mcm_pdas_test.go Outdated

ilanolkies commented May 13, 2025

View reviewed changes

Fix another test

518b139

ilanolkies commented May 13, 2025

View reviewed changes

Comment thread deployment/common/changeset/example/solana_transfer_mcm_test.go Outdated

Ilan added 6 commits May 13, 2025 19:59

Revert "Fix another test"

5c5a6b0

This reverts commit 518b139.

Revert "Fix solana test"

cfcd251

This reverts commit 6b7e899.

Merge branch 'develop' into zk-testing

93705ed

Tidy and fix merge conflicts

3e97929

Lint

1470393

Lint

c70741b

ilanolkies mentioned this pull request May 14, 2025

Bump CTF and CLDF #17723

Closed

Ilan added 6 commits May 14, 2025 13:29

Fix

5cb2e2e

Bump CTF

b032279

Tidy

6453556

Run gomodtidy

03e8c9f

Fix golangci-lint

6d1b817

Merge branch 'develop' into zk-testing

2b1648e

jmank88 approved these changes May 15, 2025

View reviewed changes

Tofel approved these changes May 15, 2025

View reviewed changes

Tofel closed this May 15, 2025

This was referenced May 15, 2025

Port Link Token for ZK #16990

Closed

ZK Sync gobindings smartcontractkit/chainlink-ccip#833

Merged

Port prerequisites changeset for ZK Sync #17814

Merged

This was referenced Jun 3, 2025

Zksync gethwrappers generation deployment #17008

Closed

Zksync full #17047

Closed

ZK Sync deployment #17194

Closed

CCIP for ZK Sync #17457

Closed

Conversation

ilanolkies commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Requires

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ilanolkies May 13, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 13, 2025

Uh oh!

Uh oh!

ilanolkies May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cl-sonarqube-production Bot commented May 15, 2025

Quality Gate passed

Uh oh!

github-actions Bot commented May 15, 2025

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ilanolkies commented Apr 24, 2025 •

edited

Loading

ilanolkies May 13, 2025 •

edited

Loading