ZK Sync gobindings#833
Merged
Merged
Conversation
matYang
reviewed
Apr 24, 2025
ilanolkies
requested review from
0xAustinWang,
0xnogo,
asoliman92,
dimkouv,
makramkd,
matYang and
winder
makramkd
reviewed
Apr 28, 2025
These are necessary for testing v1.6 changesets
Contributor
Author
|
We need to move code to https://github.com/smartcontractkit/chainlink-deployments-framework + fix merge conflicts |
jhweintraub
approved these changes
May 16, 2025
jhweintraub
reviewed
May 16, 2025
jhweintraub
suggested changes
May 16, 2025
added 3 commits
May 16, 2025 19:22
RensR
reviewed
May 19, 2025
| .PHONY: wrappers-zksync | ||
| wrappers-zksync: pnpmdep foundry-zksync | ||
| ZKSYNC=true ./scripts/compile_all | ||
| ZKSYNC=true go generate ./gobindings |
Collaborator
There was a problem hiding this comment.
can we replace these two lines with ZKSYNC=true make wrappers. Probably also means you don't need pnpmdep as the main wrapper call already has it
RensR
previously approved these changes
May 19, 2025
jhweintraub
previously approved these changes
May 19, 2025
|
jhweintraub
approved these changes
May 19, 2025
0xAustinWang
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chainlink-evm/gethwrappers/generation/generate/zksyncg++Implementation:
./scripts/compile_allandgo generate ./gobindingsnow accept the envZKSYNC=trueto pick generation procedure. By doing this we avoid writing new compilation scripts andgo_generate.go, or copy/pasting its lines.Related PRs:
Notes:
chains/evm/scripts/install_forge_zksyncwas "copy/pasted" fromchainlink-evmto prevent having it as a dependencyg++bytecode with some manual changes. The implementation is also inchainlink-zksyncrepo.Next steps: if necessary, we can refactor the wrappers into a new repo or import this wrappers from
chainlink-evm. It will require some work (setup CI, security, readme, etc.). We can move forward with this and then analyze how to refactor properly once we start using it.