Add zksync compilation scripts#3
Merged
Merged
Conversation
pavel-raykov
reviewed
Apr 8, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 15 out of 19 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- contracts/.gitignore: Language not supported
- contracts/GNUmakefile: Language not supported
- contracts/scripts/zksync_compile_all: Language not supported
- go.mod: Language not supported
Contributor
There was a problem hiding this comment.
Copilot reviewed 15 out of 19 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- contracts/.gitignore: Language not supported
- contracts/GNUmakefile: Language not supported
- contracts/scripts/zksync_compile_all: Language not supported
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
gethwrappers/generation/generate/zksync/zksyncwrapper.go:77
- Only replacing two occurrences of 'PlaceholderContractName' may leave additional placeholders (e.g. in NewPlaceholderContractName and related metadata) unreplaced, potentially causing inconsistencies in the generated bindings. Consider using a global replacement or confirming that only two substitutions are needed.
template = strings.Replace(template, "PlaceholderContractName", contractName, 2)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot reviewed 15 out of 19 changed files in this pull request and generated 2 comments.
Files not reviewed (4)
- contracts/.gitignore: Language not supported
- contracts/GNUmakefile: Language not supported
- contracts/scripts/zksync_compile_all: Language not supported
- go.mod: Language not supported
added 2 commits
April 21, 2025 12:08
This enables using bytcode from other kind of artifacts
RensR
previously approved these changes
Apr 22, 2025
DylanTinianov
previously approved these changes
Apr 22, 2025
chainchad
previously approved these changes
Apr 22, 2025
RensR
previously approved these changes
Apr 22, 2025
skudasov
previously approved these changes
Apr 22, 2025
ChrisAmora
previously approved these changes
Apr 22, 2025
jmank88
previously approved these changes
Apr 22, 2025
ilanolkies
dismissed stale reviews from jmank88, ChrisAmora, skudasov, RensR, chainchad, and DylanTinianov
via
9cb11c6
jmank88
approved these changes
Apr 22, 2025
patrickhuie19
approved these changes
Apr 22, 2025
ecPablo
approved these changes
Apr 22, 2025
DylanTinianov
approved these changes
Apr 22, 2025
ChrisAmora
approved these changes
Apr 22, 2025
RensR
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forge --zksynccommandzksync2-goFollows smartcontractkit/chainlink#17047
Enables smartcontractkit/chainlink-ccip#833