Skip to content

Bump CTF and CLDF#17723

Closed
ilanolkies wants to merge 2 commits into
developfrom
bump-ctf-cldf
Closed

Bump CTF and CLDF#17723
ilanolkies wants to merge 2 commits into
developfrom
bump-ctf-cldf

Conversation

@ilanolkies
Copy link
Copy Markdown
Contributor

@ilanolkies ilanolkies commented May 14, 2025

Bumping

  • github.com/smartcontractkit/chainlink-deployments-framework v0.1.1
  • github.com/smartcontractkit/chainlink-testing-framework/framework v0.7.9

Supports

#17436

@ilanolkies ilanolkies requested review from a team as code owners May 14, 2025 16:13
@ilanolkies ilanolkies requested a review from krehermann May 14, 2025 16:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@ilanolkies ilanolkies requested review from a team as code owners May 14, 2025 16:26
@jmank88
Copy link
Copy Markdown
Contributor

jmank88 commented May 14, 2025

This is introducing a ton of dependencies. Where are they all coming from? Are they necessary? +100-200 at onces seems like an accident.

@jmank88
Copy link
Copy Markdown
Contributor

jmank88 commented May 14, 2025

This is introducing a ton of dependencies. Where are they all coming from? Are they necessary? +100-200 at once seems like an accident.

Here is the cause: smartcontractkit/chainlink-testing-framework#1823

@ilanolkies
Copy link
Copy Markdown
Contributor Author

ilanolkies commented May 14, 2025

@jmank88 I added ZK Sync dependencies. But there could be others that come from versions that were not bumped...

@ilanolkies
Copy link
Copy Markdown
Contributor Author

ilanolkies commented May 14, 2025

Ok, it makes sense... how should we handle this? I am trying to get this in for a long time now #17436 ... things keep changing and I am updating PRs all the time...

@cl-sonarqube-production
Copy link
Copy Markdown

cl-sonarqube-production Bot commented May 14, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

AnieeG
AnieeG approved these changes May 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@AnieeG AnieeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. please get the mock files removal reviewed from keystone team

@ilanolkies
Copy link
Copy Markdown
Contributor Author

ilanolkies commented May 15, 2025

Bumped in #17436

1 similar comment
@ilanolkies
Copy link
Copy Markdown
Contributor Author

ilanolkies commented May 15, 2025

Bumped in #17436

@ilanolkies ilanolkies closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tofel Tofel Tofel approved these changes

@AnieeG AnieeG AnieeG approved these changes

@krehermann krehermann Awaiting requested review from krehermann krehermann is a code owner automatically assigned from smartcontractkit/foundations

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@matYang matYang Awaiting requested review from matYang matYang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ilanolkies @jmank88 @Tofel @AnieeG