ci: fix size metrics failures and remove broken repo-stats#14023
Merged
HTRamsey merged 1 commit intomavlink:masterfrom Feb 25, 2026
Merged
ci: fix size metrics failures and remove broken repo-stats#14023HTRamsey merged 1 commit intomavlink:masterfrom
HTRamsey merged 1 commit intomavlink:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses persistent Size Metrics failures in CI by replacing the benchmark-action/github-action-benchmark approach (which failed due to sparse checkout preventing git checkout - after gh-pages branch operations) with a simpler cache-based solution. It also removes the failing repo-stats.yml workflow that used the archived lowlighter/metrics action, and deletes the now-unused ensure-branch composite action.
Changes:
- Replaced benchmark-action with GitHub Actions cache for storing/comparing size metrics baselines
- Implemented custom JavaScript comparison and PR comment posting for binary size reports
- Removed repo-stats.yml workflow that used deprecated lowlighter/metrics action
- Removed ensure-branch composite action (no longer needed)
- Changed size-metrics job permissions from contents: write to contents: read (security improvement)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/repo-stats.yml | Deleted entire workflow that used archived lowlighter/metrics action |
| .github/workflows/performance.yml | Replaced benchmark-action with cache-based approach; implemented custom size comparison in JavaScript; removed ensure-branch from sparse-checkout; reduced permissions |
| .github/actions/ensure-branch/action.yml | Deleted composite action that created gh-pages branch (no longer needed) |
Contributor
Build ResultsPlatform Status
Pre-commit
Pre-commit hooks: 32 passed, 82 failed, 10 skipped. Artifact Sizes
Total size increased by 11.65 MB Updated: 2026-02-25 07:35:21 UTC • Triggered by: Linux |
fb2fefb to
6c8baf3
Compare
cad5247 to
08f8167
Compare
08f8167 to
390478f
Compare
3485a5f to
244ec2c
Compare
244ec2c to
292ace4
Compare
b3e1b5b to
3ed7600
Compare
Replace benchmark-action/github-action-benchmark with cache-based baseline comparison for binary size tracking. On master push the metrics are cached; on PRs the baseline is restored and compared, posting a size report comment. This eliminates the gh-pages branch dependency and fixes the sparse-checkout conflict that caused persistent Size Metrics failures. Remove repo-stats.yml which used the unmaintained lowlighter/metrics action (failing 4/5 recent runs, output unused). Remove the now unreferenced ensure-branch composite action.
3ed7600 to
b6139f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchmark-action/github-action-benchmarkaction was failing on every master push because sparse checkout preventedgit checkout -after switching togh-pages. Replaced with a cache-based approach: baseline metrics are cached on master push, restored and compared on PRs, with a size report comment posted automatically.repo-stats.yml— used the archivedlowlighter/metricsaction which was failing 4/5 recent runs and producing no usable output.ensure-branchaction — no longer referenced after the benchmark-action removal.Test plan
ensure-branch,benchmark-action, orlowlighter/metrics