Skip to content

ci: fix size metrics failures and remove broken repo-stats#14023

Merged
HTRamsey merged 1 commit intomavlink:masterfrom
HTRamsey:fix/ci-fixes
Feb 25, 2026
Merged

ci: fix size metrics failures and remove broken repo-stats#14023
HTRamsey merged 1 commit intomavlink:masterfrom
HTRamsey:fix/ci-fixes

Conversation

@HTRamsey
Copy link
Copy Markdown
Collaborator

Summary

  • Fix persistent Size Metrics failures — the benchmark-action/github-action-benchmark action was failing on every master push because sparse checkout prevented git checkout - after switching to gh-pages. Replaced with a cache-based approach: baseline metrics are cached on master push, restored and compared on PRs, with a size report comment posted automatically.
  • Remove repo-stats.yml — used the archived lowlighter/metrics action which was failing 4/5 recent runs and producing no usable output.
  • Remove ensure-branch action — no longer referenced after the benchmark-action removal.

Test plan

  • Merge to master triggers size-metrics job; baseline is cached without errors
  • Subsequent PR triggers size comparison and posts a Binary Size Report comment
  • No remaining references to ensure-branch, benchmark-action, or lowlighter/metrics

Copilot AI review requested due to automatic review settings February 24, 2026 00:14
@github-actions github-actions bot added github_actions Pull requests that update GitHub Actions code size/S labels Feb 24, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses persistent Size Metrics failures in CI by replacing the benchmark-action/github-action-benchmark approach (which failed due to sparse checkout preventing git checkout - after gh-pages branch operations) with a simpler cache-based solution. It also removes the failing repo-stats.yml workflow that used the archived lowlighter/metrics action, and deletes the now-unused ensure-branch composite action.

Changes:

  • Replaced benchmark-action with GitHub Actions cache for storing/comparing size metrics baselines
  • Implemented custom JavaScript comparison and PR comment posting for binary size reports
  • Removed repo-stats.yml workflow that used deprecated lowlighter/metrics action
  • Removed ensure-branch composite action (no longer needed)
  • Changed size-metrics job permissions from contents: write to contents: read (security improvement)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/repo-stats.yml Deleted entire workflow that used archived lowlighter/metrics action
.github/workflows/performance.yml Replaced benchmark-action with cache-based approach; implemented custom size comparison in JavaScript; removed ensure-branch from sparse-checkout; reduced permissions
.github/actions/ensure-branch/action.yml Deleted composite action that created gh-pages branch (no longer needed)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 24, 2026

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View
All builds passed.

Pre-commit

Check Status Details
pre-commit Failed View

Pre-commit hooks: 32 passed, 82 failed, 10 skipped.

Artifact Sizes

Artifact Size Δ from master
QGroundControl-aarch64.AppImage 195.92 MB +6.29 MB (increase)
QGroundControl-installer-AMD64-ARM64.exe 76.93 MB
QGroundControl-installer-AMD64.exe 164.99 MB
QGroundControl-installer-ARM64.exe 77.88 MB
QGroundControl-mac.apk 187.71 MB
QGroundControl-windows.apk 187.74 MB
QGroundControl-x86_64.AppImage 187.58 MB +10.02 MB (increase)
QGroundControl.apk 332.47 MB
QGroundControl.dmg 318.74 MB -4.66 MB (decrease)
size-metrics.AppImage 0.00 MB
test-duration-linux_gcc_64.AppImage 0.00 MB -0.00 MB (decrease)

Total size increased by 11.65 MB


Updated: 2026-02-25 07:35:21 UTC • Triggered by: Linux

@HTRamsey HTRamsey force-pushed the fix/ci-fixes branch 11 times, most recently from b3e1b5b to 3ed7600 Compare February 25, 2026 06:00
Replace benchmark-action/github-action-benchmark with cache-based
baseline comparison for binary size tracking. On master push the
metrics are cached; on PRs the baseline is restored and compared,
posting a size report comment. This eliminates the gh-pages branch
dependency and fixes the sparse-checkout conflict that caused
persistent Size Metrics failures.

Remove repo-stats.yml which used the unmaintained lowlighter/metrics
action (failing 4/5 recent runs, output unused). Remove the now
unreferenced ensure-branch composite action.
@HTRamsey HTRamsey merged commit c68adcb into mavlink:master Feb 25, 2026
28 checks passed
@HTRamsey HTRamsey deleted the fix/ci-fixes branch February 25, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants