ci: simplify size metrics and remove broken repo-stats workflow

Replace benchmark-action/github-action-benchmark with cache-based
baseline comparison for binary size tracking. On master push the
metrics are cached; on PRs the baseline is restored and compared,
posting a size report comment. This eliminates the gh-pages branch
dependency and fixes the sparse-checkout conflict that caused
persistent Size Metrics failures.

Remove repo-stats.yml which used the unmaintained lowlighter/metrics
action (failing 4/5 recent runs, output unused). Remove the now
unreferenced ensure-branch composite action.

Author: HTRamsey

.github/actions/collect-artifact-sizes/action.yml

@@ -38,7 +38,10 @@ runs:
             if (targetPlatforms.includes(run.name) &&
                 run.status === 'completed' &&
                 run.conclusion === 'success') {
-              platformRuns[run.name] = run.id;
+              const existing = platformRuns[run.name];
+              if (!existing || new Date(run.created_at) > new Date(existing.created_at)) {
+                platformRuns[run.name] = { id: run.id, created_at: run.created_at };
+              }
             }
           }
 
@@ -50,11 +53,11 @@ runs:
           };
 
           const artifacts = [];
-          for (const [platform, runId] of Object.entries(platformRuns)) {
+          for (const [platform, runInfo] of Object.entries(platformRuns)) {
             const artifactsResponse = await github.rest.actions.listWorkflowRunArtifacts({
               owner: context.repo.owner,
               repo: context.repo.repo,
-              run_id: runId
+              run_id: runInfo.id
             });
 
             for (const artifact of artifactsResponse.data.artifacts) {

.github/actions/ensure-branch/action.yml

@@ -6,11 +6,11 @@ Python helper scripts used by workflows and composite actions in this repository
 
 | Script | Purpose |
 |---|---|
+| `android_boot_test.py` | Android emulator boot smoke test |
 | `benchmark_runner.py` | Run benchmark binaries and summarize output |
 | `coverage_comment.py` | Build coverage report comments |
 | `find_binary.py` | Locate produced binaries/artifacts in build trees |
 | `generate_build_results_comment.py` | Generate consolidated PR build-results comment |
-| `generate_matrix.py` | Generate workflow matrix entries from `.github/build-config.json` |
 | `gstreamer_archive.py` | Package GStreamer builds and optionally upload to S3 |
 | `install_ccache.py` | Resolve ccache config and install pinned Linux binary |
 | `size_analysis.py` | Analyze binary size changes |
@@ -20,10 +20,5 @@ Python helper scripts used by workflows and composite actions in this repository
 Run the CI script tests locally:
 
 ```bash
-pytest -q \
-  .github/scripts/tests/test_find_binary.py \
-  .github/scripts/tests/test_generate_matrix.py \
-  .github/scripts/tests/test_generate_build_results_comment.py \
-  .github/scripts/tests/test_gstreamer_archive.py \
-  .github/scripts/tests/test_install_ccache.py
+pytest -q .github/scripts/tests/
 ```

.github/scripts/README.md

@@ -109,7 +109,7 @@ def main() -> None:
             line_delta = delta_str(baseline_cov["line"], pr_cov["line"])
             branch_delta = (
                 delta_str(baseline_cov.get("branch"), pr_cov.get("branch"))
-                if pr_cov.get("branch")
+                if pr_cov.get("branch") is not None
                 else "N/A"
             )
         else:

.github/scripts/coverage_comment.py

@@ -29,6 +29,8 @@ def _parse_coverage_percent(path: Path) -> float | None:
         return None
     try:
         root = _xml_parse(path).getroot()
+        if int(root.get("lines-valid", 0)) == 0:
+            return None
         return float(root.get("line-rate", 0.0)) * 100.0
     except Exception:
         logger.debug("Failed to parse coverage from %s", path, exc_info=True)
@@ -51,7 +53,7 @@ def _parse_precommit_results(path: Path) -> tuple[str | None, str | None, str |
     skipped = str(data.get("skipped", "0")).strip()
     run_url = str(data.get("run_url", "")).strip()
 
-    status = "Passed" if exit_code == "0" else "Failed"
+    status = "Passed" if exit_code == "0" else "Failed (non-blocking)"
     details = f"[View]({run_url})" if run_url else None
     note = f"Pre-commit hooks: {passed} passed, {failed or '0'} failed, {skipped or '0'} skipped."
     return status, details, note

.github/scripts/generate_build_results_comment.py

@@ -105,3 +105,31 @@ def test_main_with_baseline_writes_delta_table(tmp_path: Path, monkeypatch: pyte
     text = output.read_text(encoding="utf-8")
     assert "| Good Lines | 80.00% | +10.00% |" in text
     assert "| Fair Branches | 60.00% | +10.00% |" in text
+
+
+def test_main_with_zero_branch_coverage_reports_delta(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:
+    coverage_xml = tmp_path / "coverage.xml"
+    baseline_xml = tmp_path / "baseline.xml"
+    output = tmp_path / "coverage-comment.md"
+
+    _write_xml(coverage_xml, '<coverage line-rate="0.80" branch-rate="0.00"></coverage>')
+    _write_xml(baseline_xml, '<coverage line-rate="0.70" branch-rate="0.10"></coverage>')
+
+    monkeypatch.setattr(
+        sys,
+        "argv",
+        [
+            "coverage_comment.py",
+            "--coverage-xml",
+            str(coverage_xml),
+            "--baseline-xml",
+            str(baseline_xml),
+            "--output",
+            str(output),
+        ],
+    )
+
+    main()
+
+    text = output.read_text(encoding="utf-8")
+    assert "| Low Branches | 0.00% | -10.00% |" in text

.github/scripts/tests/test_coverage_comment.py

@@ -53,7 +53,7 @@ def test_generate_comment_precommit_artifact_overrides_status(tmp_path: Path) ->
 
     out = generate_comment(env, tmp_path, now_utc=datetime(2026, 2, 17, 12, 0, 0, tzinfo=UTC))
 
-    assert "| pre-commit | Failed | [View](https://example.test/precommit) |" in out
+    assert "| pre-commit | Failed (non-blocking) | [View](https://example.test/precommit) |" in out
     assert "Pre-commit hooks: 12 passed, 3 failed, 1 skipped." in out
 
 
@@ -72,10 +72,10 @@ def test_generate_comment_test_coverage_and_sizes(tmp_path: Path) -> None:
 
     coverage_path = tmp_path / "artifacts" / "coverage-report" / "coverage.xml"
     coverage_path.parent.mkdir(parents=True)
-    coverage_path.write_text('<coverage line-rate="0.75" />', encoding="utf-8")
+    coverage_path.write_text('<coverage line-rate="0.75" lines-valid="100" />', encoding="utf-8")
 
     baseline_coverage = tmp_path / "baseline-coverage.xml"
-    baseline_coverage.write_text('<coverage line-rate="0.70" />', encoding="utf-8")
+    baseline_coverage.write_text('<coverage line-rate="0.70" lines-valid="100" />', encoding="utf-8")
 
     pr_sizes = tmp_path / "pr-sizes.json"
     pr_sizes.write_text(

.github/scripts/tests/test_generate_build_results_comment.py

@@ -49,7 +49,8 @@ jobs:
         with:
           fetch-depth: 1
 
-      - name: Get build config
+      - name: Get build config (clazy/iwyu)
+        if: contains(fromJSON('["clazy", "iwyu"]'), inputs.tool)
         id: config
         uses: ./.github/actions/build-config
 
@@ -69,52 +70,50 @@ jobs:
         with:
           extra-packages: iwyu clang ninja-build
 
-      - name: Install Dependencies (sanitizers)
-        if: contains(fromJSON('["asan", "ubsan", "tsan"]'), inputs.tool)
-        uses: ./.github/actions/install-dependencies
-
-      - name: Install Qt
+      - name: Install Qt (clazy/iwyu)
+        if: contains(fromJSON('["clazy", "iwyu"]'), inputs.tool)
         uses: ./.github/actions/qt-install
         with:
           version: ${{ steps.config.outputs.qt_version }}
           host: linux
           arch: linux_gcc_64
           modules: ${{ steps.config.outputs.qt_modules }}
 
-      - name: Configure
-        working-directory: ${{ runner.temp }}/build
-        env:
-          CC: ${{ inputs.tool == 'iwyu' && 'clang' || '' }}
-          CXX: ${{ inputs.tool == 'iwyu' && 'clang++' || '' }}
-        run: |
-          CMAKE_ARGS=(
-            -S "${{ github.workspace }}"
-            -B .
-            -G Ninja
-            -DCMAKE_BUILD_TYPE=Debug
+      - name: Build Setup (sanitizers)
+        if: contains(fromJSON('["asan", "ubsan", "tsan"]'), inputs.tool)
+        uses: ./.github/actions/build-setup
+        with:
+          qt-host: linux
+          qt-arch: linux_gcc_64
+          build-type: Debug
+          save-cache: false
+
+      - name: Install Dependencies (sanitizers)
+        if: contains(fromJSON('["asan", "ubsan", "tsan"]'), inputs.tool)
+        uses: ./.github/actions/install-dependencies
+
+      - name: Configure (clazy/iwyu)
+        if: contains(fromJSON('["clazy", "iwyu"]'), inputs.tool)
+        uses: ./.github/actions/cmake-configure
+        with:
+          build-dir: ${{ runner.temp }}/build
+          build-type: Debug
+          extra-args: >-
             -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
-          )
-
-          if [[ "${{ contains(fromJSON('["asan", "ubsan", "tsan"]'), inputs.tool) }}" == "true" ]]; then
-            CMAKE_ARGS+=(
-              -DQGC_BUILD_TESTING=ON
-              -DQGC_ENABLE_COVERAGE=OFF
-            )
-
-            case "${{ inputs.tool }}" in
-              asan)
-                CMAKE_ARGS+=(-DQGC_ENABLE_ASAN=ON)
-                ;;
-              ubsan)
-                CMAKE_ARGS+=(-DQGC_ENABLE_UBSAN=ON)
-                ;;
-              tsan)
-                CMAKE_ARGS+=(-DQGC_ENABLE_TSAN=ON)
-                ;;
-            esac
-          fi
+            ${{ inputs.tool == 'iwyu' && '-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++' || '' }}
 
-          "${QT_ROOT_DIR}/bin/qt-cmake" "${CMAKE_ARGS[@]}"
+      - name: Configure (sanitizers)
+        if: contains(fromJSON('["asan", "ubsan", "tsan"]'), inputs.tool)
+        uses: ./.github/actions/cmake-configure
+        with:
+          build-dir: ${{ runner.temp }}/build
+          build-type: Debug
+          testing: 'true'
+          extra-args: >-
+            -DQGC_ENABLE_COVERAGE=OFF
+            ${{ inputs.tool == 'asan' && '-DQGC_ENABLE_ASAN=ON' || '' }}
+            ${{ inputs.tool == 'ubsan' && '-DQGC_ENABLE_UBSAN=ON' || '' }}
+            ${{ inputs.tool == 'tsan' && '-DQGC_ENABLE_TSAN=ON' || '' }}
 
       - name: Build (sanitizers only)
         if: contains(fromJSON('["asan", "ubsan", "tsan"]'), inputs.tool)
@@ -188,14 +187,14 @@ jobs:
         env:
           ASAN_OPTIONS: ${{ inputs.tool == 'asan' && 'detect_leaks=1:halt_on_error=1:check_initialization_order=1' || '' }}
           LSAN_OPTIONS: ${{ inputs.tool == 'asan' && format('suppressions={0}/build/asan_suppressions.txt', runner.temp) || '' }}
-          UBSAN_OPTIONS: ${{ inputs.tool == 'ubsan' && 'print_stacktrace=1:halt_on_error=1' || '' }}
+          UBSAN_OPTIONS: ${{ inputs.tool == 'ubsan' && format('print_stacktrace=1:halt_on_error=1:suppressions={0}/build/ubsan_suppressions.txt', runner.temp) || '' }}
           TSAN_OPTIONS: ${{ inputs.tool == 'tsan' && format('second_deadlock_stack=1:halt_on_error=1:suppressions={0}/build/tsan_suppressions.txt', runner.temp) || '' }}
         with:
           build-dir: ${{ runner.temp }}/build
           junit-output: junit-results-analysis-${{ inputs.tool }}.xml
           ctest-output: sanitizer-output.txt
           include-labels: 'Unit|Integration'
-          exclude-labels: 'Flaky|Network'
+          exclude-labels: 'Flaky|Network|NoSanitizer'
           parallel: '1'
 
       - name: Upload Output

.github/workflows/analysis.yml

@@ -165,7 +165,7 @@ jobs:
             -DQT_ANDROID_ABIS=${{ env.QT_ANDROID_ABIS }}
             -DQT_HOST_PATH=${{ env.QT_ROOT_DIR }}/../${{ matrix.qt_host_path }}
             -DQT_ANDROID_SIGN_APK=ON
-            ${{ matrix.emulator && '-DQT_ANDROID_APPLICATION_ARGUMENTS=--simple-boot-test' || '' }}
+            ${{ matrix.emulator && '-DQT_ANDROID_APPLICATION_ARGUMENTS="--simple-boot-test"' || '' }}
 
       - name: Build
         uses: ./.github/actions/cmake-build

.github/workflows/android.yml

@@ -31,9 +31,12 @@ jobs:
   upload:
     name: Upload Sources
     if: >-
-      github.event_name == 'push' ||
-      (github.event_name == 'pull_request' && github.event.pull_request.merged == true) ||
-      (github.event_name == 'workflow_dispatch' && inputs.action == 'upload')
+      github.repository_owner == 'mavlink' &&
+      (
+        github.event_name == 'push' ||
+        (github.event_name == 'pull_request' && github.event.pull_request.merged == true) ||
+        (github.event_name == 'workflow_dispatch' && inputs.action == 'upload')
+      )
     runs-on: ubuntu-latest
     timeout-minutes: 15
     permissions:
@@ -64,8 +67,11 @@ jobs:
   download:
     name: Download Translations
     if: >-
-      github.event_name == 'schedule' ||
-      (github.event_name == 'workflow_dispatch' && inputs.action == 'download')
+      github.repository_owner == 'mavlink' &&
+      (
+        github.event_name == 'schedule' ||
+        (github.event_name == 'workflow_dispatch' && inputs.action == 'download')
+      )
     runs-on: ubuntu-latest
     timeout-minutes: 15
     permissions: