Skip to content

fix: resolve WAVE accessibility issues#1489

Open
saurabhhhcodes wants to merge 1 commit into
magic-peach:mainfrom
saurabhhhcodes:fix/wave-accessibility-178
Open

fix: resolve WAVE accessibility issues#1489
saurabhhhcodes wants to merge 1 commit into
magic-peach:mainfrom
saurabhhhcodes:fix/wave-accessibility-178

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

Summary

  • removes the duplicate/nested main-content landmark by keeping the root layout as the single main landmark
  • adds a programmatic label for the preset search input
  • wraps text weight choices in a valid fieldset/legend group
  • gives adjustment reset buttons clearer accessible names
  • darkens the light-mode muted token to reduce small-text contrast alerts

Why

These changes address concrete WAVE-style accessibility findings: duplicate landmarks/IDs, unlabeled controls, invalid grouping semantics, unclear control names, and low-contrast muted text in light mode.

Closes #178

Verification

  • git diff --check
  • npx tsc --noEmit
  • npm run lint passes with the existing react-hooks/exhaustive-deps warning in src/components/VideoEditor.tsx:276
  • npm run build

Test note

  • npm test -- --run is currently blocked by existing test harness issues unrelated to this patch: Vitest cannot resolve the @/utils/fontLoader alias in FFmpeg-related tests, and ThemeToggle.test.tsx runs without a localStorage shim.

Signed-off-by: Saurabh Kumar Bajpai <157192462+saurabhhhcodes@users.noreply.github.com>
@vercel

vercel Bot commented Jun 1, 2026

Copy link
Copy Markdown

@saurabhhhcodes is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @saurabhhhcodes!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @saurabhhhcodes

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:testing Testing labels Jun 1, 2026
@saurabhhhcodes

Copy link
Copy Markdown
Author

Hi @magic-peach, this PR closes the assigned GSSoC issue #178. Could you please add/confirm the GSSoC labels (gssoc'26, gssoc:approved) during review if the scope looks good?

Note: the Vercel status is pointing to the Vercel Git authorization URL, while the repo automation checks (label, welcome, and validate) are green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Accessibility] Conduct WAVE tool audit and fix all errors

1 participant