fix: resolve WAVE accessibility issues#1489
Open
saurabhhhcodes wants to merge 1 commit into
Open
Conversation
Signed-off-by: Saurabh Kumar Bajpai <157192462+saurabhhhcodes@users.noreply.github.com>
|
@saurabhhhcodes is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @saurabhhhcodes!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @saurabhhhcodesBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Author
|
Hi @magic-peach, this PR closes the assigned GSSoC issue #178. Could you please add/confirm the GSSoC labels ( Note: the Vercel status is pointing to the Vercel Git authorization URL, while the repo automation checks ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main-contentlandmark by keeping the root layout as the single main landmarkfieldset/legendgroupWhy
These changes address concrete WAVE-style accessibility findings: duplicate landmarks/IDs, unlabeled controls, invalid grouping semantics, unclear control names, and low-contrast muted text in light mode.
Closes #178
Verification
git diff --checknpx tsc --noEmitnpm run lintpasses with the existingreact-hooks/exhaustive-depswarning insrc/components/VideoEditor.tsx:276npm run buildTest note
npm test -- --runis currently blocked by existing test harness issues unrelated to this patch: Vitest cannot resolve the@/utils/fontLoaderalias in FFmpeg-related tests, andThemeToggle.test.tsxruns without a localStorage shim.