Skip to content

fix: resolve WAVE accessibility issues #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve WAVE accessibility issues #1489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
--surface: #f1f5f9;
--border: #cbd5e1;
--text: #0f172a;
--muted: #64748b;
--muted: #475569;
--accent: #3b82f6;
--accent-hover: #1d4ed8;
--accent-muted: rgba(59, 130, 246, 0.12);
Expand Down Expand Up @@ -152,4 +152,4 @@ detail > summary {
}
details > summary::-webkit-details-marker {
display: none;
}
}
4 changes: 2 additions & 2 deletions src/app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ export default function Home() {
⭐ Star on GitHub
</a>

<main id="main-content" tabIndex={-1}>
<div>
<VideoEditor />
</main>
</div>

<Footer />
</>
Expand Down
6 changes: 5 additions & 1 deletion src/components/PresetSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,14 @@ export default function PresetSelector({ recipe, onChange }: Props) {
</div>

<div className="relative">
<label htmlFor="preset-search" className="sr-only">
Search output formats
</label>
<div className="pointer-events-none absolute inset-y-0 left-0 flex items-center pl-3">
<Search size={14} className="text-[var(--muted)]" />
</div>
<input
id="preset-search"
type="text"
placeholder="Search formats..."
value={search}
Expand Down Expand Up @@ -335,4 +339,4 @@ export default function PresetSelector({ recipe, onChange }: Props) {
)}
</div>
);
}
}
4 changes: 2 additions & 2 deletions src/components/TextControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ export default function TextControls({
</div>

{/* Font Weight */}
<div>
<fieldset>
<legend className="text-xs text-[var(--muted)] font-medium mb-1 block">
Weight
</legend>
Expand All @@ -233,7 +233,7 @@ export default function TextControls({
</button>
))}
</div>
</div>
</fieldset>
</div>
)}
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/components/VideoEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ return () => {
type="button"
onClick={() => updateRecipe({ brightness: 0 })}
className="text-film-500 hover:underline"
aria-label="reset brightness"
aria-label="Reset brightness adjustment"
>
Reset
</button>
Expand All @@ -594,7 +594,7 @@ return () => {
type="button"
onClick={() => updateRecipe({ contrast: 1 })}
className="text-film-500 hover:underline"
aria-label="reset-contrast"
aria-label="Reset contrast adjustment"
>
Reset
</button>
Expand All @@ -619,7 +619,7 @@ return () => {
type="button"
onClick={() => updateRecipe({ saturation: 1 })}
className="text-film-500 hover:underline"
aria-label="reset-saturation"
aria-label="Reset saturation adjustment"
>
Reset
</button>
Expand Down