Skip to content

fix(a11y): resolve WAVE audit control issues#1446

Closed
saurabhhhcodes wants to merge 1 commit into
magic-peach:mainfrom
saurabhhhcodes:fix/wave-a11y-errors-178
Closed

fix(a11y): resolve WAVE audit control issues#1446
saurabhhhcodes wants to merge 1 commit into
magic-peach:mainfrom
saurabhhhcodes:fix/wave-a11y-errors-178

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

Fixes #178

Summary

  • add programmatic names for hidden upload/search controls so WAVE and screen readers do not see unlabeled inputs
  • mark decorative icons/ratio boxes as hidden and add pressed states to preset, overlay, and text-selection controls
  • replace the orphaned text weight legend with a real fieldset and add clearer trim-slider instructions/value text
  • tighten light-theme muted/accent/warning/error tokens to pass WCAG AA contrast on white and surface backgrounds

Verification

  • npm run lint (passes; existing VideoEditor exhaustive-deps warning remains)
  • npx tsc --noEmit
  • npm run build (passes; same existing warning)
  • token contrast sanity check: muted/accent/warning/error pairs are now >= 4.5:1 on light backgrounds

Note: I also attempted an axe CLI run against the static build, but the local ChromeDriver bundled by the tool only supports Chrome 149 while this workstation has Chrome 148, so that browser audit could not run locally.

@vercel

vercel Bot commented May 31, 2026

Copy link
Copy Markdown

@saurabhhhcodes is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix labels May 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @saurabhhhcodes!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @saurabhhhcodes

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@saurabhhhcodes

Copy link
Copy Markdown
Author

Hi maintainers, this is for assigned issue #178. Could you please add gssoc:approved and type:accessibility during review if the scope looks right?

Local verification completed:

  • npm run lint (passes; existing VideoEditor exhaustive-deps warning remains)
  • npx tsc --noEmit
  • npm run build
  • contrast sanity check for light-theme muted/accent/warning/error tokens, all now >= 4.5:1 on white/surface backgrounds

Vercel is showing the usual fork authorization status, not a code failure.

@saurabhhhcodes

Copy link
Copy Markdown
Author

Closing this older duplicate in favor of #1489, which covers the same #178 accessibility scope with the cleaner/current patch and better label coverage. Keeping one PR open for review to avoid duplicate maintainer work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:intermediate Intermediate level - 35 pts type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Accessibility] Conduct WAVE tool audit and fix all errors

1 participant