[smach_to_mail] Add NOTIFICATION_LEVEL #1648
Open
mqcmd196 wants to merge 2 commits intojsk-ros-pkg:masterfrom
Open
[smach_to_mail] Add NOTIFICATION_LEVEL #1648mqcmd196 wants to merge 2 commits intojsk-ros-pkg:masterfrom
mqcmd196 wants to merge 2 commits intojsk-ros-pkg:masterfrom
Conversation
mqcmd196
added
the
hacktoberfest-accepted
Member
|
this is interesting, but could provide any good example/senario of using this new feature? ( Is it important/impressive than k-okada#76 (comment), enable smach to respond to replies from chat client? ) |
mqcmd196
force-pushed
the
PR/smach_notification_level
branch
from
cd26f6a to
d9d4e22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1578
I added notification level parameters in smach_to_state for deciding whether to notify each medium according to the importance of the information. It sounds like deciding logging level, like DEBUG, INFO, WARN, ERROR, FATAL... for each medium. It is strange for using WARN, ERROR, FATAL in this context, so I use DEBUG, INFO, NOTICE, CRITICAL, EMERGENCY instead (c.f. https://success.trendmicro.com/dcx/s/solution/TP000086250?language=en_US SEVERITY LEVEL)