Adopt Google Chat ROS to smach_to_mail and adding launch file for it#1578
Adopt Google Chat ROS to smach_to_mail and adding launch file for it#1578k-okada merged 10 commits intojsk-ros-pkg:masterfrom
Conversation
This reverts commit ef5786d.
mqcmd196
force-pushed
the
smach_to_state
branch
from
011167e to
29c638f
Compare
| "({})".format(x['INFO']) if x['INFO'] else '')) | ||
| self._send_mail(self.smach_state_subject[caller_id], self.smach_state_list[caller_id]) | ||
| self._send_twitter(self.smach_state_subject[caller_id], self.smach_state_list[caller_id]) | ||
| if self.use_mail: |
There was a problem hiding this comment.
If you do not want to publish /email /twitter and /google_chat all time, how about write code to check if there are topic subscrribers, instead of asking users to manually set use_email manually.
if rospy.get_num_connections() > 0:
rospy.publish("email")
There was a problem hiding this comment.
I think the node for handling email, twitter, chatting should be launched all time, and if we want to suppress the notification, the demo code or this smach notification system should do it.
There was a problem hiding this comment.
I think the node for handling email, twitter, chatting should be launched all time, and if we want to suppress the notification, the demo code or this smach notification system should do it.
I am for this idea. We set default notification interfaces when robot starts, but robots should switch to better interfaces dependent on demo or behavior.
For example, we can use info data for switching notification interface or embed the message which interface should be used in user_data, though I still don't know what is the better way so much..
There was a problem hiding this comment.
So, I think this implementation is almost OK and the function of switching to better interfaces may be our near future work.
There was a problem hiding this comment.
how about using dynamic reconfigure to change parameters dynamically?
rosparam only loaded at the beginning, so other node cannot change it.
or user_data can contain the info, too.
also I think we dont need to suppress the notification from the beginning.
When someone says it is annoying, we can think about it probably 🤣
There was a problem hiding this comment.
I'm looking into ways to set the importance of smach information
There was a problem hiding this comment.
how about using dynamic reconfigure to change parameters dynamically?
rosparam only loaded at the beginning, so other node cannot change it.or user_data can contain the info, too.
also I think we dont need to suppress the notification from the beginning.
When someone says it is annoying, we can think about it probably rofl
Sorry I overlooked this comment... and I've just created suppressing node by setting notification level dyn param. Please check #1648
|
please resolve the conflicts |
4 participants
Same with k-okada#72 .
Using Google Chat in
smach_to_mail.pyand adding launch file.Example output