-
Notifications
You must be signed in to change notification settings - Fork 94
Adopt Google Chat ROS to smach_to_mail and adding launch file for it #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
883c524
[jsk_robot_startup] add google_chat notification in smach_to_state
mqcmd196 58e3bde
[jsk_robot_startup] add default google_chat space name
mqcmd196 aa7e369
[jsk_robot_startup] using card instead
mqcmd196 09dcaf2
[jsk_robot_startup] fix google_chat smach notification sending image
mqcmd196 64b7e3f
[jsk_robot_startup] add gdrive_ros dependency
mqcmd196 6e1d913
[jsk_robot_startup] update readme for smach_to_mail.py with google_chat
mqcmd196 7247982
Revert "[jsk_robot_startup] add gdrive_ros dependency"
mqcmd196 29c638f
[jsk_robot_startup] add launch file for smach_to_mail
mqcmd196 69637b2
[jsk_robot_startup] update readme for smach_to_mail.launch
mqcmd196 1fcd322
[smach_to_state] resolve conflicts
mqcmd196 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
jsk_robot_common/jsk_robot_startup/launch/smach_to_mail.launch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <launch> | ||
| <arg name="use_mail" default="true" /> | ||
| <arg name="use_twitter" default="true" /> | ||
| <arg name="use_google_chat" default="true" /> | ||
| <arg name="email_sender_address" default="" /> | ||
| <arg name="email_receiver_address" default="" /> | ||
| <arg name="google_chat_space" default="" /> | ||
| <arg name="namespace" default="smach_to_mail" /> | ||
|
|
||
| <group if="$(arg use_mail)" ns="$(arg namespace)"> | ||
| <param name="sender_address" value="$(arg email_sender_address)" /> | ||
| <param name="receiver_address" value="$(arg email_reveiver_address)" /> | ||
| </group> | ||
| <group if="$(arg use_google_chat)" ns="$(arg namespace)"> | ||
| <param name="google_chat_space" value="$(arg google_chat_space)" /> | ||
| </group> | ||
|
|
||
| <node name="$(arg namespace)" pkg="jsk_robot_startup" type="smach_to_mail.py" output="screen"> | ||
| <rosparam subst_value="true"> | ||
| use_mail: $(arg use_mail) | ||
| use_twitter: $(arg use_twitter) | ||
| use_google_chat: $(arg use_google_chat) | ||
| </rosparam> | ||
| </node> | ||
|
|
||
| </launch> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do not want to publish
/email/twitterand/google_chatall time, how about write code to check if there are topic subscrribers, instead of asking users to manually setuse_emailmanually.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the node for handling email, twitter, chatting should be launched all time, and if we want to suppress the notification, the demo code or this smach notification system should do it.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am for this idea. We set default notification interfaces when robot starts, but robots should switch to better interfaces dependent on demo or behavior.
For example, we can use
infodata for switching notification interface or embed the message which interface should be used inuser_data, though I still don't know what is the better way so much..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I think this implementation is almost OK and the function of switching to better interfaces may be our near future work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about using dynamic reconfigure to change
parametersdynamically?rosparamonly loaded at the beginning, so other node cannot change it.or
user_datacan contain the info, too.also I think we dont need to suppress the notification from the beginning.
When someone says it is annoying, we can think about it probably 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking into ways to set the importance of smach information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I overlooked this comment... and I've just created suppressing node by setting
notification leveldyn param. Please check #1648