fix(i18n): drop generic concept words from DEFAULT_PROTECTED_TERMS fallback#224
Merged
Merged
Conversation
…llback DEFAULT_PROTECTED_TERMS is the Gemini "keep-English" fallback used by getKeepEnglishTerms() only when a locale has no _protected keys. It still listed skill, Subagent, Enterprise, Personal, Plugin, and Dispatch — generic concept words that PR #218 deliberately REMOVED from the per-locale _protected blocks because they are translated natively per locale (concept-vs-product-name policy, docs/TRANSLATION_RULES.md §1). Keeping them in the fallback told Gemini to keep ordinary words in English — the opposite of the shipped policy. Reduced to brand/product/file-format proper nouns only: API, SDK, Claude, Anthropic, Claude Code, Cowork, Computer Use, SKILL.md, frontmatter. Low-impact (the fallback only fires for a locale with an empty _protected), but it removes a policy inconsistency a future contributor/LLM pass could be misled by. Surfaced by the doc fact-check in #223. 555 unit (constants assertions unchanged) · gates green · e2e 20/20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small policy-consistency cleanup surfaced by the #223 doc fact-check.
DEFAULT_PROTECTED_TERMS(constants.js) is the Gemini keep-English fallback — used bygetKeepEnglishTerms()only when a locale has no_protectedkeys. It still listedskill,Subagent,Enterprise,Personal,Plugin,Dispatch— generic concept words that #218 deliberately removed from the per-locale_protectedblocks because they are translated natively (concept-vs-product-name policy, docs/TRANSLATION_RULES.md §1). Keeping them in the fallback told Gemini to keep ordinary words English — the opposite of the shipped policy.Reduced to brand/product/file-format proper nouns only:
API, SDK, Claude, Anthropic, Claude Code, Cowork, Computer Use, SKILL.md, frontmatter.Low-impact (the fallback only fires for a locale with an empty
_protected), but it removes an inconsistency a future contributor or automated pass could be misled by.555 unit (the
constantsassertions — contains Claude/Anthropic/API — still hold) · gates green · e2e 20/20.🤖 Generated with Claude Code