Skip to content

Commit 6c013a0

Browse files
authored
fix(i18n): drop generic concept words from DEFAULT_PROTECTED_TERMS fallback (#224)
DEFAULT_PROTECTED_TERMS is the Gemini "keep-English" fallback used by getKeepEnglishTerms() only when a locale has no _protected keys. It still listed skill, Subagent, Enterprise, Personal, Plugin, and Dispatch — generic concept words that PR #218 deliberately REMOVED from the per-locale _protected blocks because they are translated natively per locale (concept-vs-product-name policy, docs/TRANSLATION_RULES.md §1). Keeping them in the fallback told Gemini to keep ordinary words in English — the opposite of the shipped policy. Reduced to brand/product/file-format proper nouns only: API, SDK, Claude, Anthropic, Claude Code, Cowork, Computer Use, SKILL.md, frontmatter. Low-impact (the fallback only fires for a locale with an empty _protected), but it removes a policy inconsistency a future contributor/LLM pass could be misled by. Surfaced by the doc fact-check in #223. 555 unit (constants assertions unchanged) · gates green · e2e 20/20.
1 parent cb1fd0f commit 6c013a0

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

src/lib/constants.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,13 @@ const SKILLBRIDGE_MODELS = {
1414

1515
// ==================== DEFAULTS ====================
1616

17-
const DEFAULT_PROTECTED_TERMS =
18-
'API, SDK, Claude, Anthropic, Claude Code, Cowork, Dispatch, Computer Use, Subagent, Enterprise, Personal, Plugin, skill, SKILL.md, frontmatter';
17+
// Gemini "keep-English" fallback, used by getKeepEnglishTerms() only when a locale
18+
// has no _protected keys. Brand/product/file-format proper nouns ONLY — generic
19+
// concept words (skill, Subagent, Enterprise, Personal, Plugin, Dispatch) were
20+
// dropped here to match PR #218, which removed them from the per-locale _protected
21+
// blocks because they are translated natively per locale (see docs/TRANSLATION_RULES.md
22+
// §1). Keeping them would tell Gemini to keep ordinary words English.
23+
const DEFAULT_PROTECTED_TERMS = 'API, SDK, Claude, Anthropic, Claude Code, Cowork, Computer Use, SKILL.md, frontmatter';
1924

2025
// YouTube InnerTube client version — update periodically as needed
2126
// Source of truth: src/shared/constants.json (keep in sync; validated by scripts/check-bg-sync.js)

0 commit comments

Comments
 (0)