fix(compliance, support): reviewer feedback#1087
Merged
Merged
Conversation
- Support dashboard issue: link UserData ID to /support/user/:id when
compliance access is not available (mirrors the existing compliance
link for ADMIN/COMPLIANCE roles).
- Call queue user info: surface the Phone Call Accepted flag next to
Phone Call Status (was missing from all queue overviews, noticed in
ManualCheckIpCountryPhone).
- Call queue outcome form: make the comment required so every call
decision is documented; mark the label with * and disable Save until
a comment is entered.
- Stammdaten AddressChange comparison: resolve the new country name via
the loaded countries list; AddressChange step results only persist
{ id } (see kyc-data.dto.ts), so 'Land' was always rendered as '-'.
- Settings context: expose the full countries list so consumers can
resolve country references by id without re-fetching.
6 tasks
- Compliance review panel: clickable URL values in result table
(OperationalActivity websiteUrl etc.); left-align check rows so
wrapped labels do not center under the inherited text-center layout.
- Compliance review panel: resolve {legalEntity} placeholder via the
LegalEntity KYC step result so the Handelsregister check label shows
the real legal form (AG / GmbH / ...) instead of "-".
- Lock down compliance decision UI when a step or bank-data entry is in
InternalReview status: hide accept/reject + save controls, show an
inline notice. Applies to ComplianceReviewPanel, IdentPanel,
StammdatenPanel and BankDataReviewPanel.
- Call queue outcome dropdown: remove Reset entry — not a real outcome
for phone calls. CallOutcome.RESET removed from the enum and the
now-unreachable RESET branch in saveCallOutcome cleaned up.
- Extract extractLegalEntity() into compliance-helpers and reuse it in
both header and review panel.
- Ident panel: load birthday from the ident step result (with userData fallback). At Ident review time userData.birthday is typically not populated yet. - Pending reviews list: one row per Type/Name with InternalReview and ManualReview counts side by side. Only the ManualReview list is expandable (InternalReview cases are still being processed by the API), columns reordered so InternalReview comes first. - Pending reviews → user navigation: include the matching tab in the URL (?tab=...) so opening from the list lands on the correct tab instead of the default. - Bank data review: filter out type='Ident' entries (created from KYC ident results, not relevant for compliance) and surface alternative approved bank data with the same IBAN, including two yes/no questions to support the decision. - Bank data lockout: only ManualReview can be accepted/rejected by compliance; all other statuses show an inline notice. - Compliance dashboard: new "Pending Transactions" section listing AML pending cases (amlReason=ManualCheck, amlCheck=Pending). Clicking a row opens the user's compliance review with the AML Pending tab pre-selected. - Global layout: enable textStart on compliance review, compliance user, call queue detail and support dashboard issue screens so wrapped labels are left-aligned by default instead of inheriting text-center from the layout wrapper.
3 tasks
Collaborator
Author
|
API-Seite (BankData alternatives + Pending Transactions endpoint) ist in DFXswiss/api#3689 |
- Reorder the review tabs to follow the customer onboarding flow. AML Pending, BankData Review and Stammdaten are now grouped on the left (transaction review / post-onboarding admin), visually separated from the KYC onboarding tabs on the right. - Add tabs for the previously missing steps: Recommendation, SoleProprietorshipConfirmation, Statutes and RealUnitRegistration. - Stronger visual separator (2px blue line, mx-4) between the two tab groups so it is obvious the left block is not part of KYC. - Count badges on AML Pending / BankData Review now use dark blue background with white text for proper contrast in light mode.
davidleomay
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ongoing fix branch addressing reviewer feedback for the Compliance and Support tools. New fixes will land as additional commits on this branch.
Current changes
/compliance/user/:id, others →/support/user/:id. (support-dashboard-issue.screen.tsx)call-queue-user-info.tsx)*, placeholder updated, Save button stays disabled until a non-empty comment is entered. (call-queue-outcome-form.tsx)countrieslist. The AddressChange step result only stores{ id }(seekyc-data.dto.ts), so the new country was always rendered as-. (stammdaten-panel.tsx)countrieslist so consumers can resolve country references by id. (settings.context.tsx)Reviewer feedback items already verified as fixed in develop (no code changes)
Germany (undefined)in user data overview → fixed by refactor refactor(compliance): extract display helpers, split-pane hook and i18n #1083 (refName()).compliance/pending-reviews/:type/:nameroute was removed in feat: compliance call queues #1076; reviews are now inline rows on the compliance screen.support/call-queues/clerks).Test plan
/support/user/:id/compliance/user/:id{ id: N }) → "Land" right column shows the resolved country namenpm test), lint and typecheck remain green