fix(support): compliance reviewer feedback (api side)#3689
Draft
bernd2022 wants to merge 1 commit into
Draft
Conversation
- BankData: expose approved alternatives with the same IBAN (different bankData id) on the support endpoint so the compliance BankData review can surface collisions across users. Added BankDataAlternative DTO and BankDataService.getApprovedAlternatives (single batched query). - Pending Transactions: new GET /support/pending-transactions endpoint returning BuyCrypto + BuyFiat with amlReason=ManualCheck and amlCheck=Pending, used by the new Pending Transactions section on the compliance dashboard. Added PendingTransactionInfo DTO.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API-side changes that go with the services PR DFXswiss/services#1087.
Changes
alternatives— other approved BankData rows that share the same IBAN (different id). Compliance uses this in the BankData review to spot user collisions. AddedBankDataAlternativeDTO andBankDataService.getApprovedAlternatives()which fetches all alternatives in a single batched query (In(ibans)/Not(In(ids))).GET /support/pending-transactionsthat returns BuyCrypto + BuyFiat withamlReason=ManualCheckandamlCheck=Pending. Used by the new Pending Transactions section on the compliance dashboard. AddedPendingTransactionInfoDTO.Test plan
GET /v1/support/:idreturns each BankData with optionalalternativesarray; for entries with a same-IBAN approved counterpart at a different user, the array contains the other entry (id, userDataId, name, verifiedName, accountType, type).GET /v1/support/pending-transactionsreturns the expected list (matches what the AML Pending tab shows per user).npm test,npm run lint,npx tsc --noEmitremain green.