fix(compliance, support): reviewer feedback#1086
Closed
bernd2022 wants to merge 1 commit into
Closed
Conversation
- Support dashboard issue: link UserData ID to /support/user/:id when
compliance access is not available (mirrors the existing compliance
link for ADMIN/COMPLIANCE roles).
- Call queue user info: surface the Phone Call Accepted flag next to
Phone Call Status (was missing from all queue overviews, noticed in
ManualCheckIpCountryPhone).
- Call queue outcome form: make the comment required so every call
decision is documented; mark the label with * and disable Save until
a comment is entered.
- Stammdaten AddressChange comparison: resolve the new country name via
the loaded countries list; AddressChange step results only persist
{ id } (see kyc-data.dto.ts), so 'Land' was always rendered as '-'.
- Settings context: expose the full countries list so consumers can
resolve country references by id without re-fetching.
bernd2022
changed the title
6 tasks
Collaborator
Author
|
Replaced by #1087 (branch was renamed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ongoing fix branch addressing reviewer feedback for the Compliance and Support tools. New fixes will land as additional commits on this branch.
Current changes
/compliance/user/:id, others →/support/user/:id. (support-dashboard-issue.screen.tsx)call-queue-user-info.tsx)*, placeholder updated, Save button stays disabled until a non-empty comment is entered. (call-queue-outcome-form.tsx)countrieslist. The AddressChange step result only stores{ id }(seekyc-data.dto.ts), so the new country was always rendered as-. (stammdaten-panel.tsx)countrieslist so consumers can resolve country references by id. (settings.context.tsx)Reviewer feedback items already verified as fixed in develop (no code changes)
Germany (undefined)in user data overview → fixed by refactor refactor(compliance): extract display helpers, split-pane hook and i18n #1083 (refName()).compliance/pending-reviews/:type/:nameroute was removed in feat: compliance call queues #1076; reviews are now inline rows on the compliance screen.support/call-queues/clerks).Test plan
/support/user/:id/compliance/user/:id{ id: N }) → "Land" right column shows the resolved country namenpm test), lint and typecheck remain green