Skip to content

Split gw-pressure into vented and unvented#444

Merged
bpbond merged 4 commits intomainfrom
vented
Jan 24, 2026
Merged

Split gw-pressure into vented and unvented#444
bpbond merged 4 commits intomainfrom
vented

Conversation

@bpbond
Copy link
Copy Markdown
Member

@bpbond bpbond commented Jan 22, 2026

Split the gw-pressure variable into gw-pressure-vented (used for AQ600s) and gw-pressure-unvented (for the 200s).

This seems to fix the 200s being flagged as OOB (this is from the test data, so numbers are small):

# A tibble: 30 × 6
   Site  Plot  Instrument   Instrument_ID `FALSE` `TRUE`
   <chr> <chr> <chr>        <chr>           <int>  <int>
 1 CRC   TR    AquaTROLL600 B                  12      0
 2 CRC   UP    AquaTROLL600 A                  12      0
 3 CRC   W     AquaTROLL600 C                  12      0
 4 GCW   TR    AquaTROLL600 B                  12      0
 5 GCW   UP    AquaTROLL200 683451              6      0
 6 GCW   UP    AquaTROLL600 685442              0      6
 7 GCW   W     AquaTROLL600 C                  12      0
 8 GWI   TR    AquaTROLL600 B                  12      0
 9 GWI   UP    AquaTROLL600 A                  12      0
10 GWI   W     AquaTROLL600 C                  12      0
11 MSM   TR    AquaTROLL600 B                  12      0
12 MSM   UP    AquaTROLL600 A                  12      0
13 MSM   W     AquaTROLL600 C                  12      0
14 OWC   W     AquaTROLL600 C                  12      0
15 OWC   WTE   AquaTROLL600 B                  12      0
16 PTR   TR    AquaTROLL600 B                   9      0
17 PTR   UP    AquaTROLL600 A                  11      0
18 PTR   W     AquaTROLL600 C                  13      0
19 SWH   SWAMP AquaTROLL600 A                3030      0
20 SWH   SWAMP AquaTROLL600 A_new               4      0
21 SWH   TR    AquaTROLL600 B                   6      0
22 SWH   UP    AquaTROLL600 B                  12      4
23 SWH   UP    AquaTROLL600 B_new              10      0
24 TMP   C     AquaTROLL200 683451              6      0
25 TMP   C     AquaTROLL600 685442              0      6
26 TMP   F     AquaTROLL200 683345              6      0
27 TMP   F     AquaTROLL200 683416              6      0
28 TMP   F     AquaTROLL600 685474              0      6
29 TMP   S     AquaTROLL200 683408              6      0
30 TMP   S     AquaTROLL600 685410              0      6

Closes #443

@bpbond bpbond requested a review from stephpenn1 January 22, 2026 15:46
@bpbond bpbond marked this pull request as ready for review January 22, 2026 16:10
@bpbond bpbond added this to the v2-1 milestone Jan 22, 2026
@bpbond
Copy link
Copy Markdown
Member Author

bpbond commented Jan 22, 2026

Maybe I will rerun the v2-1 L1 release and summarize results here before we merge this?

@stephpenn1
Copy link
Copy Markdown
Member

Maybe I will rerun the v2-1 L1 release and summarize results here before we merge this?

Yes I think good idea, also see #445 before you do a rerun

@bpbond
Copy link
Copy Markdown
Member Author

bpbond commented Jan 22, 2026

Here's what things now look like:

pressure

The AQ200s in TMP are getting mapped to gw-pressure-unvented and correctly not being flagged as OOB.

There are two AQ600s (685474 and 685442) that are unvented and not being marked as such.

@bpbond
Copy link
Copy Markdown
Member Author

bpbond commented Jan 22, 2026

Oh it looks like we have some data duplication:

tmp_by_instrument

@bpbond
Copy link
Copy Markdown
Member Author

bpbond commented Jan 22, 2026

tmp_by_oob

OK @stephpenn1 I think that we're OK here, as long as you're good with splitting gw-pressure into the two vented and unvented variables. I will try to fix the issue above (data duplication) via a separate issue, but I think the split itself is working correctly and documentation updates tell users about each variable; also documented in the v2-1 README. So at your leisure please evaluate and approve if things look okay.

@bpbond bpbond merged commit f3a5e47 into main Jan 24, 2026
1 check passed
@bpbond bpbond deleted the vented branch January 24, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unvented Aquatroll pressure incorrectly flagged as OOB in L1

2 participants