Conversation
Member
Author
|
Maybe I will rerun the v2-1 L1 release and summarize results here before we merge this? |
Member
Yes I think good idea, also see #445 before you do a rerun |
Member
Author
Member
Author
Member
Author
OK @stephpenn1 I think that we're OK here, as long as you're good with splitting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Split the
gw-pressurevariable intogw-pressure-vented(used for AQ600s) andgw-pressure-unvented(for the 200s).This seems to fix the 200s being flagged as OOB (this is from the test data, so numbers are small):
Closes #443