Unvented Aquatroll pressure incorrectly flagged as OOB in L1

[stephpenn1]

The troll pressure OOB ranges are based on vented pressure values, which incorrectly flags the troll 200s which are unvented. I see two four potential solutions

1. Create a different variable name (see Why is TMP Aquatroll so OOB #437 (comment))
2. Correct the unvented pressure in L2 (annoying and potentially a lot of work)
3. Remove or expand the OOB range to include both types (not ideal long term)
4. Something better @bpbond will likely come up with

Freshwater

Saltwater

Control

[stephpenn1]

Also potentially related to #397

[bpbond]

Thanks @stephpenn1 - well summarized.

1. Create a different variable name (see Why is TMP Aquatroll so OOB Why is TMP Aquatroll so OOB #437 (comment))

This is maybe the best solution in theory? Not too much work, very clear for users.

2. Correct the unvented pressure in L2 (annoying and potentially a lot of work)

Medium-hard but possible. But to identify the unvented pressures we'd have to implement number 1 or 3 anyway!

3. Remove or expand the OOB range to include both types (not ideal long term)

This is the easiest short-term solution. That way both the vented and unvented data pass through to L2. Downside is less robust flagging and we're putting the burden on the users to figure this out and correct the unvented data.

4. Something better @bpbond will likely come up with

Unlikely! 🤔 the only other thing I that occurs to me would be to back-correct all the data and keep doing that. Hugely unappealing.

[bpbond]

My vote is number 1. Vented and unvented pressures are fundamentally different, and so deserve different variable names.

[bpbond]

> dat %>% group_by(Site, Plot, Instrument, Instrument_ID, F_OOB) %>% summarise(n = n(), .groups = "drop") %>% pivot_wider(names_from = "F_OOB", values_from = "n", values_fill = 0) %>% print(n=100)
# A tibble: 35 × 7
   Site  Plot  Instrument   Instrument_ID `FALSE` `TRUE`  `NA`
   <chr> <chr> <chr>        <chr>           <int>  <int> <int>
 1 CRC   TR    AquaTROLL600 B              130654   1047     0
 2 CRC   UP    AquaTROLL600 A              166283      0     0
 3 CRC   W     AquaTROLL600 C              154824    810     0

 4 GCW   TR    AquaTROLL600 B              113250      2     0

 7 GCW   W     AquaTROLL600 C               99271      0     0

 8 GWI   TR    AquaTROLL600 B              174735   1923     0
 9 GWI   UP    AquaTROLL600 A              166276      0     0
10 GWI   W     AquaTROLL600 C              112141      0     0

11 MSM   TR    AquaTROLL600 B              175031      0     0
12 MSM   UP    AquaTROLL600 A              155743   2363     0
13 MSM   W     AquaTROLL600 C              169398      0     0

14 OWC   TR    AquaTROLL600 A               19472      0     0
15 OWC   TR    AquaTROLL600 B               75900      0     0
16 OWC   W     AquaTROLL600 C              173862      1     0
17 OWC   WTE   AquaTROLL600 A                   2      0     0
18 OWC   WTE   AquaTROLL600 B              172681      0     0
19 OWC   WTE   AquaTROLL600 C                   1      0     0

20 PTR   TR    AquaTROLL600 B              186798      0     0
21 PTR   UP    AquaTROLL600 A              173247   2771     0
22 PTR   W     AquaTROLL600 C              179536      0     0

23 SWH   SWAMP AquaTROLL600 A              136220      0     0
24 SWH   SWAMP AquaTROLL600 A_new            5421      0     0
25 SWH   TR    AquaTROLL600 B              117993      0     0
26 SWH   UP    AquaTROLL600 B               80756      3     0
27 SWH   UP    AquaTROLL600 B_new            5404      0     0
28 SWH   W     AquaTROLL600 C              132272      0     0

29 TMP   C     AquaTROLL200 683451             25 193960     0
30 TMP   C     AquaTROLL600 685442         396544 106248     6
31 TMP   F     AquaTROLL200 683345              0 292159     0
32 TMP   F     AquaTROLL200 683416             22 307021     0
33 TMP   F     AquaTROLL600 685474         316407 124615   109
34 TMP   S     AquaTROLL200 683408              0 263115     0
35 TMP   S     AquaTROLL600 685410         366028  75136    13

[bpbond]

OK, from the table above, we're talking about

• The AQ200s at TMP
• Some of the AQ600 data at TMP (haven't we corrected this like TWICE??!?!?!?) Correct non-vented Aquatroll600 pressure600 data #357 Non-vented and vented troll issue - GCW only #342

[stephpenn1]

You mentioned this as being not fixed yet via email but I see here it was closed in #444, did you mean #433?

[bpbond]

Sorry for any confusion. This was merged but we were still seeing OOB flags, which led me to investigate further and discover the bad-file issue fixed in #448 .