Fix file corruption and straighten out vented/unvented at TMP#448
Merged
Fix file corruption and straighten out vented/unvented at TMP#448
Conversation
Member
Author
|
One disadvantage is that people may go back to asking @wilsonsj100 about why the troll pressure data readings are so high. But hopefully the |
Member
Author
|
This may also fix #445 -- it would make sense. But I have not confirmed that. |
stephpenn1
approved these changes
Jan 26, 2026
Member
stephpenn1
left a comment
There was a problem hiding this comment.
This looks great, thanks for your detailed work here. Fingers crossed it fixes #443
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK, whew, this took some investigative work.
We had several problems:
read_datalogger_file()in L0 was generating a warning that was being ignored, because there were more columns than column namesThis PR:
gw-pressure-ventedandgw-pressure-unventedresearch names merged in Split gw-pressure into vented and unvented #444The result is I think what we want:
Closes #446