Skip to content

Fix file corruption and straighten out vented/unvented at TMP#448

Merged
bpbond merged 10 commits intomainfrom
corruption-fix
Jan 26, 2026
Merged

Fix file corruption and straighten out vented/unvented at TMP#448
bpbond merged 10 commits intomainfrom
corruption-fix

Conversation

@bpbond
Copy link
Copy Markdown
Member

@bpbond bpbond commented Jan 24, 2026

OK, whew, this took some investigative work.

We had several problems:

This PR:

The result is I think what we want:

Screenshot 2026-01-24 at 11 00 08 Screenshot 2026-01-24 at 10 48 17 Screenshot 2026-01-24 at 10 49 03

Closes #446

@bpbond
Copy link
Copy Markdown
Member Author

bpbond commented Jan 24, 2026

One disadvantage is that people may go back to asking @wilsonsj100 about why the troll pressure data readings are so high. But hopefully the gw-pressure-vented and gw-pressure-unvented variable names, and their accompanying documentation, will mitigate this.

@bpbond bpbond requested a review from stephpenn1 January 24, 2026 16:06
@bpbond
Copy link
Copy Markdown
Member Author

bpbond commented Jan 24, 2026

This may also fix #445 -- it would make sense. But I have not confirmed that.

@bpbond bpbond added this to the v2-1 milestone Jan 26, 2026
Copy link
Copy Markdown
Member

@stephpenn1 stephpenn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for your detailed work here. Fingers crossed it fixes #443

@bpbond bpbond merged commit bb75876 into main Jan 26, 2026
1 check passed
@bpbond bpbond deleted the corruption-fix branch January 26, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Oh it looks like we have some data duplication:

2 participants