Mission: Do not send notifications about messages for completed missions

[muramura]

The GCS can download a MISSION from the FC before executing it.
The MISSION contains sequence numbers. Each time the FC completes a MISSION item, it sends a MISSION_ITEM_REACHED notification.
The GCS can obtain commands and other information from the notified sequence numbers.
Therefore, I want to prevent the FC from sending messages.

MP displays the current sequence number on the HUD.

AFTER

BEFORE

MISSION_ITEM_REACHED

[tpwrules]

This will break RC telemetry systems capable of conveying messages such as ELRS.

[andyp1per]

This will break RC telemetry systems capable of conveying messages such as ELRS.

Yes agreed. Closing on that basis.

[muramura]

@andyp1per san.
ELRS is less common than SBUS. Should we configure it to send when using ELRS?

I would like this PR to be reopened. ELRS is used by some people, but many more use SBUS

[peterbarker]

@muramura We could move to sending the same data via an actual protocol rather than text - but it seems some people are relying on the text currently.

Note also #27779 which would be a nice replacement for the text messages, but GCS support will be years in the making!

[andyp1per]

There are lots of systems that rely on the text that the flight controller sends (not just this text but lots of messages) - this PR appears to break that assumption - I can't see how that is useful. I mean maybe a config option to turn down the spam?

[timtuxworth]

@muramura We could move to sending the same data via an actual protocol rather than text - but it seems some people are relying on the text currently.

Note also #27779 which would be a nice replacement for the text messages, but GCS support will be years in the making!

Having an interface depend the structure and information contained in a text message is a very, very bad idea. These 2 PR's combined seem like a much better idea.

If we make it an option we can start now and in a few years when the GCS support is there, we will have a much better system.

[timtuxworth]

Having an interface depend the structure and information contained in a text message is a very, very bad idea. These 2 PR's combined seem like a much better idea.

Every time I read this I want to add another "very". :-)