fix(main): use tempfile.mkstemp for collision-safe writable directory check#1349
Merged
amilcarlucas merged 2 commits intorefactor_mainfrom Mar 4, 2026
Merged
fix(main): use tempfile.mkstemp for collision-safe writable directory check#1349amilcarlucas merged 2 commits intorefactor_mainfrom
amilcarlucas merged 2 commits intorefactor_mainfrom
Conversation
…leanup in _is_directory_writable Co-authored-by: amilcarlucas <24453563+amilcarlucas@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on code refactor for testability and readability improvements
fix(main): use tempfile.mkstemp for collision-safe writable directory check
Mar 4, 2026
amilcarlucas
approved these changes
Mar 4, 2026
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_is_directory_writableused a fixed.write_test.tmpfilename, causing potential collisions and flaky results when multiple processes/threads run the check concurrently in the same directory. Cleanup also only happened on the happy path.Changes
path / ".write_test.tmp"withtempfile.mkstemp(dir=path), producing a distinct file per callunlink+closeinto afinallyblock so the temp file is always removed, even if the write raises mid-way✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.