Skip to content

fix(main): use tempfile.mkstemp for collision-safe writable directory check #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amilcarlucas merged 2 commits into from
Mar 4, 2026
Merged

fix(main): use tempfile.mkstemp for collision-safe writable directory check #1349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f26fdbd
Initial plan
Copilot Mar 4, 2026
f5b8ec7
fix(main): use tempfile.mkstemp for unique tmp file and finally for c…
Copilot Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ardupilot_methodic_configurator/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import argparse
import os
import tempfile
from logging import basicConfig as logging_basicConfig
from logging import debug as logging_debug
from logging import error as logging_error
Expand Down Expand Up @@ -286,11 +287,13 @@ def _is_directory_writable(path: Path) -> bool:
return False
try:
path.mkdir(parents=True, exist_ok=True)
test_file = path / ".write_test.tmp"
with open(test_file, "w", encoding="utf-8") as tmp:
tmp.write("test")
test_file.unlink(missing_ok=True)
return True
fd, tmp_path = tempfile.mkstemp(dir=path)
try:
os.write(fd, b"test")
return True
finally:
os.close(fd)
Path(tmp_path).unlink(missing_ok=True)
except OSError:
return False

Expand Down
Loading