refactor(main): make the code more testable and easier to read

[amilcarlucas]

No description provided.

[Copilot]

Pull request overview

Refactors the main entrypoint to improve readability and testability by extracting connection and vehicle-directory resolution logic into dedicated functions.

Changes:

• Split FC connection + vehicle type resolution into connect_to_fc() and resolve_vehicle_type().
• Extracted vehicle directory selection/writability logic into get_preferred_vehicle_dir() and resolve_writable_vehicle_dir_for_initial_download().
• Added tests covering the new behavior and updated existing connection tests to patch the new progress context manager.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
tests/test__main__.py	Adds/updates unit tests for new connection progress patching and vehicle directory resolution helpers.
ardupilot_methodic_configurator/main.py	Refactors FC connection/vehicle type logic and extracts vehicle directory resolution + writability checks into helpers.

[Copilot]

Using a fixed filename (.write_test.tmp) can cause collisions if multiple instances/threads/processes run this check concurrently in the same directory (one call can delete/overwrite another’s file and produce flaky results). Consider generating a unique temp filename (e.g., via tempfile with the target directory) and ensure cleanup happens in a finally block so the temp file is removed even if the write fails mid-way.

[amilcarlucas]

@copilot open a new pull request to apply changes based on this feedback

[Copilot]

This test case models an args object without a vehicle_dir attribute, but in real usage argparse.Namespace typically includes the attribute (often set to None). Add a test where args.vehicle_dir exists but is None (and/or empty) to cover the realistic fallback behavior and prevent regressions like Path(None) raising.

Suggested change

	def test_falls_back_to_cwd_when_vehicle_dir_is_none(self) -> None:
	"""Given args.vehicle_dir is None, preferred directory should be current working directory."""
	mock_args = MagicMock()
	mock_args.vehicle_dir = None
	with patch("ardupilot_methodic_configurator.__main__.Path.cwd", return_value=Path("C:/cwd")):
	result = get_preferred_vehicle_dir(mock_args)
	assert result == Path("C:/cwd")

[Copilot]

@amilcarlucas I've opened a new pull request, #1349, to work on those changes. Once the pull request is ready, I'll request review from you.

[github-actions]

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
11564	10528	91%	89%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
ardupilot_methodic_configurator/main.py	75%	🟢
TOTAL	75%	🟢

updated for commit: d6fedc7 by action🐍

[github-actions]

Test Results

    2 files      2 suites   28m 30s ⏱️
3 032 tests 3 027 ✅  5 💤 0 ❌
6 064 runs  6 054 ✅ 10 💤 0 ❌

Results for commit d6fedc7.