Skip to content

chore: pin portlet-api to JSR-286, trim maven-war-plugin version, align CI to Java 11#56

Merged
bjagg merged 1 commit intouPortal-Project:masterfrom
bjagg:chore/renovate-pin-portlet-api-v2-and-trim-war-plugin
Apr 23, 2026
Merged

chore: pin portlet-api to JSR-286, trim maven-war-plugin version, align CI to Java 11#56
bjagg merged 1 commit intouPortal-Project:masterfrom
bjagg:chore/renovate-pin-portlet-api-v2-and-trim-war-plugin

Conversation

@bjagg
Copy link
Copy Markdown
Member

@bjagg bjagg commented Apr 23, 2026

Summary

Three small cleanups. All related to "stay consistent with uPortal runtime reality and reduce Renovate noise."

renovate.json — block portlet-api v3+

uPortal runs Portlet API 2.0 (JSR-286). Portlet API 3.x (JSR-362) is a different container contract. Renovate keeps proposing the bump (#22). allowedVersions: "< 3.0" stops regeneration.

pom.xml — drop maven-war-plugin version

The <plugin> block has to stay (project-specific <webResources> + plugin-scoped plexus-archiver override). But the <version>3.4.0</version> is redundant vs. parent's pluginManagement. Dropping it means future parent bumps propagate.

CI.yml — align Java matrix to 11-only

uPortal-start deploys on Java 11. Testing exclusively on Java 17/21 gave false confidence and risked a dep compiled for Java 17+ bytecode slipping through. AnnouncementsPortlet, NewsReaderPortlet, and resource-server already test Java 11 only — this brings basiclti into alignment.

Closes #22.

Test plan

  • mvn validate passes
  • mvn help:effective-pom confirms maven-war-plugin resolves to 3.4.0 from parent

🤖 Generated with Claude Code

… version

renovate.json: block javax.portlet:portlet-api major-version bumps.
uPortal runs Portlet API 2.0 (JSR-286) and does not support the
Portlet API 3.x (JSR-362) container contract. Renovate keeps
proposing portlet-api v3 (see PR uPortal-Project#22); block it at the source so
the proposal stops regenerating.

pom.xml: drop the <version>3.4.0</version> pin on maven-war-plugin.
The plugin block stays (it carries project-specific <configuration>
for the docs webResources include, and a plugin-scoped
<dependencies> entry for plexus-archiver that can't inherit from
project dM). But the version is now provided by
uportal-portlet-parent:47's pluginManagement, so future parent bumps
(e.g. renovate/org.apache.maven.plugins-maven-war-plugin-3.x)
propagate automatically.
@bjagg bjagg merged commit a79a66d into uPortal-Project:master Apr 23, 2026
8 checks passed
@bjagg bjagg changed the title chore: pin portlet-api to JSR-286 in renovate + drop maven-war-plugin version chore: pin portlet-api to JSR-286, trim maven-war-plugin version, align CI to Java 11 Apr 23, 2026
@bjagg bjagg mentioned this pull request Apr 23, 2026
2 tasks
bjagg added a commit that referenced this pull request Apr 23, 2026
uPortal-start deploys on Java 11, but CI was testing exclusively
on Java 17/21 — which gave false confidence and risked a
dependency compiled for Java 17+ bytecode slipping through and
breaking at runtime on the deployed JVM.

Other portlets already running this matrix: AnnouncementsPortlet,
NewsReaderPortlet, resource-server. This brings basiclti into
alignment.

(Companion PR to the 6 opened against the other portlets;
originally intended to be part of #56 but that merged before the
amend landed.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant