chore: pin portlet-api to JSR-286, trim maven-war-plugin version, align CI to Java 11#56
Merged
bjagg merged 1 commit intouPortal-Project:masterfrom Apr 23, 2026
Conversation
… version renovate.json: block javax.portlet:portlet-api major-version bumps. uPortal runs Portlet API 2.0 (JSR-286) and does not support the Portlet API 3.x (JSR-362) container contract. Renovate keeps proposing portlet-api v3 (see PR uPortal-Project#22); block it at the source so the proposal stops regenerating. pom.xml: drop the <version>3.4.0</version> pin on maven-war-plugin. The plugin block stays (it carries project-specific <configuration> for the docs webResources include, and a plugin-scoped <dependencies> entry for plexus-archiver that can't inherit from project dM). But the version is now provided by uportal-portlet-parent:47's pluginManagement, so future parent bumps (e.g. renovate/org.apache.maven.plugins-maven-war-plugin-3.x) propagate automatically.
2 tasks
bjagg
added a commit
that referenced
this pull request
Apr 23, 2026
uPortal-start deploys on Java 11, but CI was testing exclusively on Java 17/21 — which gave false confidence and risked a dependency compiled for Java 17+ bytecode slipping through and breaking at runtime on the deployed JVM. Other portlets already running this matrix: AnnouncementsPortlet, NewsReaderPortlet, resource-server. This brings basiclti into alignment. (Companion PR to the 6 opened against the other portlets; originally intended to be part of #56 but that merged before the amend landed.)
This was referenced Apr 23, 2026
chore: pin renovate constraints to portlet's supported versions
uPortal-Project/BookmarksPortlet#134
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small cleanups. All related to "stay consistent with uPortal runtime reality and reduce Renovate noise."
renovate.json — block portlet-api v3+
uPortal runs Portlet API 2.0 (JSR-286). Portlet API 3.x (JSR-362) is a different container contract. Renovate keeps proposing the bump (#22).
allowedVersions: "< 3.0"stops regeneration.pom.xml — drop maven-war-plugin version
The
<plugin>block has to stay (project-specific<webResources>+ plugin-scopedplexus-archiveroverride). But the<version>3.4.0</version>is redundant vs. parent's pluginManagement. Dropping it means future parent bumps propagate.CI.yml — align Java matrix to 11-only
uPortal-start deploys on Java 11. Testing exclusively on Java 17/21 gave false confidence and risked a dep compiled for Java 17+ bytecode slipping through. AnnouncementsPortlet, NewsReaderPortlet, and resource-server already test Java 11 only — this brings basiclti into alignment.
Closes #22.
Test plan
mvn validatepassesmvn help:effective-pomconfirms maven-war-plugin resolves to 3.4.0 from parent🤖 Generated with Claude Code