chore: tighten renovate pins (servlet-api, plexus-archiver, mockito)#264
Merged
bjagg merged 1 commit intouPortal-Project:masterfrom Apr 24, 2026
Merged
Conversation
Add three packageRules to stop Renovate from proposing bumps this portlet can't absorb without broader coordination. Also broaden the Spring rule to use matchPackagePrefixes so new Spring artifacts are covered automatically. - javax.servlet:servlet-api < 3.0 — this portlet compiles against the legacy artifactId at 2.5. Servlet 3.x lives at javax.servlet:javax.servlet-api (different artifactId), and the runtime container provides 3.1 via tomcat-servlet-api in the parent. Pinning prevents Renovate from chasing a never-coming 3.x bump on the 2.5 coordinate. - org.codehaus.plexus:plexus-archiver < 4.11.0 — 4.11 calls commons-io BoundedInputStream.builder(), which only exists in a newer commons-io than the one maven-war-plugin 3.4.0 bundles. (This is the same pin we added to basiclti-portlet.) Closes uPortal-Project#256. - org.mockito:mockito-core / mockito-inline / mockito-junit-jupiter < 5.0 — Mockito 5 uses the inline MockMaker by default and its bundled byte-buddy references ClassFileVersion.JAVA_V21, which the byte-buddy 1.12.x pulled transitively via Javassist doesn't have. Would break tests with "Could not initialize inline Byte Buddy mock maker". Will revisit once byte-buddy can be reconciled at the parent level. Closes uPortal-Project#235. - Spring rule broadened to matchPackagePrefixes (org.springframework:, org.springframework.data:). Catches the Dependabot Spring 6 proposals (uPortal-Project#227, uPortal-Project#229) and any future spring-* artifacts without hand-maintaining the list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add three packageRules and broaden the Spring rule so Renovate stops proposing bumps this portlet can't absorb without broader coordination.
New rules
javax.servlet:servlet-api < 3.0javax.servlet:javax.servlet-api(different artifactId). Runtime provides 3.1 viatomcat-servlet-apifrom parent.org.codehaus.plexus:plexus-archiver < 4.11.0commons-io BoundedInputStream.builder(), which only exists in a newer commons-io than the onemaven-war-plugin:3.4.0bundles. Same pin we added to basiclti-portlet#56. Closes #256.org.mockito:mockito-core/inline/junit-jupiter< 5.0ClassFileVersion.JAVA_V21, missing on the byte-buddy 1.12.x pulled transitively via Javassist. Would fail tests with "Could not initialize inline Byte Buddy mock maker". Closes #235.Change
Broadened the Spring rule to
matchPackagePrefixes: ["org.springframework:", "org.springframework.data:"]so new Spring artifacts are covered automatically (e.g. the Dependabot Spring 6 proposals #227 + #229 that hand-maintained names weren't catching).🤖 Generated with Claude Code