Added support for partial genes prokka-1.12#219
Added support for partial genes prokka-1.12#219jennahd wants to merge 1 commit intotseemann:masterfrom
Conversation
There was a problem hiding this comment.
Apart from the two small things in README.md (line 43, should be as in the original; ll. 478 and following, should be as in the original), I'd recommend accepting those changes. I believe they have been tested thoroughly. We've been using the version with --partialgene (based on prokka 1.11) in the past 2 years without issue.
Did @jcmcnh also had the opportunity to test them?
|
@jennahd @lguy @novigit This is fantastic, thank you so much! I pulled your changed code and ran it on my dataset and it works like a charm. Without the --partialgenes option enabled, I got 2525 ORFs, and with it I get 4590 ORFs! A lot of those new ones are short contigs that might be meaningless but I was also definitely was missing a lot of edge genes contained in larger contigs. Even for some of the shorter contigs that have edges on both sides, prokka gave functional annotations - information I can keep now thanks to your changes! So bottom line, it definitely works well and allows me to parse the maximum amount of meaningful data from a fragmented assembly. This will be very handy for both SAGs and metagenomes! Many thanks for sharing your hard work! |
Adding the improvement about the pull request tseemann#219 to remove the `-c` in prodigal in metagenome and adding the `--partialgenes` option. Also adding improvment (1) from issue tseemann#474
In Summary:
We (@novigit and I) applied these changes made by @lguy for prokka version 1.11 (issue #37) to prokka version 1.12.
In addition we made one other fix and completed some tests: