Update to ctaphid-dispatch v0.3.0 and release v0.3.0#20
Merged
robin-nitrokey merged 3 commits intomainfrom Mar 25, 2025
Merged
Conversation
This fixes a new compiler warning.
This was referenced Mar 21, 2025
sosthene-nitrokey
approved these changes
Mar 24, 2025
daringer
approved these changes
Mar 24, 2025
ctaphid-dispatch v0.3.0 makes Dispatch generic over the message size instead of using a constant value. This patch adapts usbd-ctaphid to this patch and changes the usbd-ctaphid buffer to use the same buffer size as ctaphid-dispatch. (Previously, we used 3072 and ctaphid-dispatch used 7609.) This means that we no longer need the MESSAGE_SIZE constant and can remove it.
This release updates ctaphid-dispatch to v0.3.0 and makes usbd-ctaphid also generic over the buffer size.
robin-nitrokey
force-pushed
the
message-size
branch
from
2830b63 to
998db11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctaphid-dispatch v0.3.0 makes Dispatch generic over the message size
instead of using a constant value. This patch adapts usbd-ctaphid to
this patch and changes the usbd-ctaphid buffer to use the same buffer
size as ctaphid-dispatch. (Previously, we used 3072 and
ctaphid-dispatch used 7609.) This means that we no longer need the
MESSAGE_SIZE constant and can remove it.
Please double-check that we can indeed use the same buffer size for usbd-ctaphid and ctaphid-dispatch.
Depends on: