Update ctaphid-dispatch to v0.3.0 and usbd-ctaphid to v0.3.0#615
Merged
robin-nitrokey merged 1 commit intomainfrom Mar 26, 2025
Merged
Update ctaphid-dispatch to v0.3.0 and usbd-ctaphid to v0.3.0#615robin-nitrokey merged 1 commit intomainfrom
robin-nitrokey merged 1 commit intomainfrom
Conversation
Collaborator
|
No significant changes. Insignifcant changes
|
Member
Author
|
This leads to a 5 kB binary size increase because we no longer use the same buffer size for ctaphid-dispatch and apdu-dispatch, so functions that are generic over the buffer size are duplicated. This mostly affects secrets-app and, to a lesser extent, admin-app, for example: I see the following options:
I think (1) would be the easiest solution and a temporary increase in binary size would be acceptable. What do you think @sosthene-nitrokey @daringer? |
This makes ctaphid generic over the buffer size and synchronizes the buffer sizes between ctaphid-dispatch and usbd-ctaphid. As the usbd-ctaphid buffer size was only about half the size of the ctaphid-dispatch buffer size, this should lead to a significantly decreased stack usage in ctaphid-dispatch calls.
e732510 to
7f6d2cf
Compare
daringer
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes ctaphid generic over the buffer size and synchronizes the buffer sizes between ctaphid-dispatch and usbd-ctaphid. As the usbd-ctaphid buffer size was only about half the size of the ctaphid-dispatch buffer size, this should lead to a significantly decreased stack usage in ctaphid-dispatch calls.
Depends on:
ctaphid-dispatch v0.2.0 is still in Cargo.lock because of webcrypt.