Skip to content

Feat: Improve card lookup by handling leading zeros in IDs #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomas-bassett wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feat: Improve card lookup by handling leading zeros in IDs #1012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions server/src/V2/endpoints/jsonEndpoints.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,14 +225,32 @@ server

let result: unknown
switch (endpoint) {
case 'cards':
// console.time('card')
result = await getCardById(lang, id)
case 'cards': {
// Try original and normalized IDs with leading zeros removed
// This is to accommodate for different ID formatting in various sets
// but also to allow current users not having to change their links
// e.g., "base1-001" will return "base1-1"
const tried = new Set<string>();
let found = false;
const parts = id.split('-');
for (let zeros = 0; zeros <= 3 && !found; zeros++) {
const newParts = [...parts];
if (parts.length > 1) {
newParts[newParts.length - 1] = newParts[newParts.length - 1].replace(new RegExp(`^0{0,${zeros}}`), '');
}
const testId = newParts.join('-');
if (!tried.has(testId)) {
result = await getCardById(lang, testId);
tried.add(testId);
if (result) found = true;
}
}
if (!result) {
result = await findOneCard(lang, { name: id })
}
// console.timeEnd('card')
break
}

case 'sets':
result = await findOneSet(lang, { id })
Expand Down