Feat: Improve card lookup by handling leading zeros in IDs#1012
Open
thomas-bassett wants to merge 1 commit intotcgdex:masterfrom
Open
Feat: Improve card lookup by handling leading zeros in IDs#1012thomas-bassett wants to merge 1 commit intotcgdex:masterfrom
thomas-bassett wants to merge 1 commit intotcgdex:masterfrom
Conversation
Updated the 'cards' endpoint to attempt fetching cards by both the original and normalized IDs with leading zeros removed. This enhances compatibility with different ID formats across sets and ensures existing user links remain functional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the 'cards' endpoint to attempt fetching cards by both the original and normalized IDs, with leading zeros removed. This enhances compatibility with different ID formats across sets and ensures existing user links remain functional.