Skip to content

[DX-3787] revamp test notifications #22334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tofel merged 3 commits into from
May 11, 2026
Merged

[DX-3787] revamp test notifications #22334

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fc762c
checkout repository before sending notifications
Tofel May 7, 2026
e76fbb5
CR changes
Tofel May 7, 2026
c91d2dc
do not persist credentials after checkout, get default branch from GH
Tofel May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions .github/workflows/post-build-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,16 @@
runs-on: ubuntu-latest
needs: [ df1-compat ]
if: always() && github.event.client_payload.slack_thread_ts
permissions:
contents: read
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

Check warning on line 127 in .github/workflows/post-build-publish.yml

View workflow job for this annotation

GitHub Actions / Validate Workflow Changes 

  1. Trusted actions should use a major version tag, if available. (trusted-tag-ref / warning)
with:
# use default branch to avoid running action from unmerged PRs and exposing secrets it uses
ref: ${{ github.event.repository.default_branch }}
persist-credentials: false

- name: Notify Slack Jobs Result
uses: ./.github/actions/notify-slack-jobs-result
Comment thread
Tofel marked this conversation as resolved.
with:
Expand All @@ -136,7 +145,15 @@
runs-on: ubuntu-latest
needs: [ cre-compat ]
if: always() && github.event.client_payload.slack_thread_ts
permissions:
contents: read
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

Check warning on line 152 in .github/workflows/post-build-publish.yml

View workflow job for this annotation

GitHub Actions / Validate Workflow Changes 

  1. Trusted actions should use a major version tag, if available. (trusted-tag-ref / warning)
with:
# use default branch to avoid running action from unmerged PRs and exposing secrets it uses
ref: ${{ github.event.repository.default_branch }}
persist-credentials: false
- name: Notify Slack Jobs Result
uses: ./.github/actions/notify-slack-jobs-result
with:
Expand All @@ -152,7 +169,15 @@
runs-on: ubuntu-latest
needs: [ legacy-system-tests ]
if: always() && github.event.client_payload.slack_thread_ts
permissions:
contents: read
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

Check warning on line 176 in .github/workflows/post-build-publish.yml

View workflow job for this annotation

GitHub Actions / Validate Workflow Changes 

  1. Trusted actions should use a major version tag, if available. (trusted-tag-ref / warning)
with:
# use default branch to avoid running action from unmerged PRs and exposing secrets it uses
ref: ${{ github.event.repository.default_branch }}
persist-credentials: false
- name: Notify Slack Jobs Result
uses: ./.github/actions/notify-slack-jobs-result
with:
Expand All @@ -168,7 +193,15 @@
runs-on: ubuntu-latest
needs: [ cre-smoke-tests ]
if: always() && github.event.client_payload.slack_thread_ts
permissions:
contents: read
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

Check warning on line 200 in .github/workflows/post-build-publish.yml

View workflow job for this annotation

GitHub Actions / Validate Workflow Changes 

  1. Trusted actions should use a major version tag, if available. (trusted-tag-ref / warning)
with:
# use default branch to avoid running action from unmerged PRs and exposing secrets it uses
ref: ${{ github.event.repository.default_branch }}
persist-credentials: false
- name: Notify Slack Jobs Result
uses: ./.github/actions/notify-slack-jobs-result
with:
Expand All @@ -184,7 +217,15 @@
runs-on: ubuntu-latest
needs: [ cre-regression-tests ]
if: always() && github.event.client_payload.slack_thread_ts
permissions:
contents: read
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

Check warning on line 224 in .github/workflows/post-build-publish.yml

View workflow job for this annotation

GitHub Actions / Validate Workflow Changes 

  1. Trusted actions should use a major version tag, if available. (trusted-tag-ref / warning)
with:
# use default branch to avoid running action from unmerged PRs and exposing secrets it uses
ref: ${{ github.event.repository.default_branch }}
persist-credentials: false
- name: Notify Slack Jobs Result
uses: ./.github/actions/notify-slack-jobs-result
with:
Expand Down
Loading