Skip to content

[DX-3787] revamp test notifications#22334

Open
Tofel wants to merge 3 commits intodevelopfrom
dx-3787-revamp-notification
Open

[DX-3787] revamp test notifications#22334
Tofel wants to merge 3 commits intodevelopfrom
dx-3787-revamp-notification

Conversation

@Tofel
Copy link
Copy Markdown
Contributor

@Tofel Tofel commented May 7, 2026

Fixed repo checkout and tested in a hijacked job:
image
image

@Tofel Tofel temporarily deployed to integration May 7, 2026 07:19 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration May 7, 2026 07:19 — with GitHub Actions Inactive
Comment thread .github/workflows/docker-build.yml Fixed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

✅ No conflicts with other open PRs targeting develop

@Tofel Tofel force-pushed the dx-3787-revamp-notification branch from e35c12f to f972582 Compare May 7, 2026 07:21
@Tofel Tofel temporarily deployed to integration May 7, 2026 07:22 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration May 7, 2026 07:22 — with GitHub Actions Inactive
@Tofel Tofel force-pushed the dx-3787-revamp-notification branch from f972582 to f5ba3d0 Compare May 7, 2026 07:26
@Tofel Tofel temporarily deployed to integration May 7, 2026 07:27 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration May 7, 2026 07:27 — with GitHub Actions Inactive
@Tofel Tofel force-pushed the dx-3787-revamp-notification branch from f5ba3d0 to 0fc762c Compare May 7, 2026 07:31
@Tofel Tofel marked this pull request as ready for review May 7, 2026 08:23
Copilot AI review requested due to automatic review settings May 7, 2026 08:23
@Tofel Tofel requested review from a team as code owners May 7, 2026 08:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: MEDIUM

This PR updates the post-build publish workflow’s Slack notification jobs to ensure they can run the local composite action by checking out the repository at a specific ref provided via repository_dispatch payload.

Changes:

  • Added actions/checkout steps to each *-notify job before invoking ./.github/actions/notify-slack-jobs-result.
  • Checks out the ref specified by github.event.client_payload.chainlink_version for those notification jobs.

Targeted areas for scrupulous human review:

  • All *-notify jobs’ permission model (workflow-level permissions: {} + job-level permissions).
  • Security implications of executing a local composite action from an event-provided ref while passing secrets.

Comment thread .github/workflows/post-build-publish.yml Outdated
Comment thread .github/workflows/post-build-publish.yml Outdated
Comment thread .github/workflows/post-build-publish.yml Outdated
Comment thread .github/workflows/post-build-publish.yml Outdated
Comment thread .github/workflows/post-build-publish.yml Outdated
Comment thread .github/workflows/post-build-publish.yml Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 7 comments.

Comment thread .github/workflows/post-build-publish.yml Outdated
Comment thread .github/workflows/post-build-publish.yml Outdated
Comment thread .github/workflows/post-build-publish.yml Outdated
Comment thread .github/workflows/post-build-publish.yml Outdated
Comment thread .github/workflows/post-build-publish.yml Outdated
Comment thread .github/workflows/post-build-publish.yml Outdated
Comment thread .github/workflows/post-build-publish.yml
@Tofel Tofel enabled auto-merge May 8, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants