fix: correct generated typescript types#559
Merged
fatso83 merged 1 commit intosinonjs:mainfrom Apr 10, 2026
Merged
Conversation
ensure generated .d.ts has no duplicate withGlobal definitions, where one is exported and the other isn't. regenerated types using `npm run types:build`
AviVahl
force-pushed
the
fix-generated-types
branch
from
3e1e6fd to
19478b5
Compare
Contributor
Author
|
I've rebased to latest @fatso83 any chance you can take a look? it's been a week since the break and everyone are locking to older versions because of this. |
Contributor
|
Hi, I expected some fallout from this, but for whatever reason, I did not see any notifications until today 🤷 Looking at it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
fixes #558
ensure generated .d.ts has no duplicate withGlobal definitions, where one is exported and the other isn't.
regenerated types using
npm run types:buildSolution - optional
explicitly set the type of the withGlobal export