fix(spanner): type conflict between @sinonjs/fake-timers and @types/sinonjs__fake-timers#7962
Merged
alkatrivedi merged 4 commits intomainfrom Apr 7, 2026
Merged
fix(spanner): type conflict between @sinonjs/fake-timers and @types/sinonjs__fake-timers#7962alkatrivedi merged 4 commits intomainfrom
alkatrivedi merged 4 commits intomainfrom
Conversation
alkatrivedi
force-pushed
the
fix-build
branch
2 times, most recently
from
d586b65 to
bf0e097
Compare
alkatrivedi
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
surbhigarg92
reviewed
Apr 6, 2026
| "overrides": { | ||
| "gcp-metadata": "^7.0.1" | ||
| "gcp-metadata": "^7.0.1", | ||
| "@sinonjs/fake-timers": "15.2.1" |
Contributor
There was a problem hiding this comment.
Please verify this change does not change the minimum version of Node or any other major components that are required to use this library ?
Contributor
Author
There was a problem hiding this comment.
since, we are already on Node 18, and not modifying the libraries engine, this fix will not change the minimum version of node or any other major component
alkatrivedi
changed the title
alkatrivedi
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
alkatrivedi
changed the title
surbhigarg92
approved these changes
Apr 7, 2026
| "overrides": { | ||
| "gcp-metadata": "^7.0.1" | ||
| "gcp-metadata": "^7.0.1", | ||
| "@sinonjs/fake-timers": "15.2.1" |
Contributor
There was a problem hiding this comment.
Do we need to fix the version to "15.2.1" . This would mean no updates will be used for this package
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves build-time TypeScript errors triggered by upstream dependency updates
Problem
When running
npm installornpm run compile, the build fails due to a type conflict between @sinonjs/fake-timers and @types/sinon (which pulls in @types/sinonjs__fake-timers). Both packages try to define symbols likewithGlobalin the global scope, leading to a Duplicate identifier 'withGlobal' errorSolution
Uses npm overrides to pin @sinonjs/fake-timers to the last known stable version (15.2.1). This eliminates the duplicate definitions at the source while preserving strict type checking for our own codebase.
Future Work
Revert this change, as soon as the fix for the conflict will be merge in fake-timer repository