Fix pre-emptive command validation in MP#2063
Merged
schombert merged 1 commit intoschombert:mainfrom Aug 25, 2025
Merged
Conversation
…re dependent on eachother were sent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue discovered by @SneakBug8 in which batch commands which were dependent on eachother (such as peacedeals) would get wrongfully invalidated as all commands in a batch would be validated prior to the execution of any of the commands.
Commands are still validated right before execution in
send_and_recieve_commands. This just removes the pre-emptive validation which happend when the host first recieves the command from clients. Also renames a function to better convey its purpose