Remove questionable transform of Select from SelectStatic#25620
Open
SolalPirelli wants to merge 2 commits intoscala:mainfrom
Open
Remove questionable transform of Select from SelectStatic#25620SolalPirelli wants to merge 2 commits intoscala:mainfrom
SelectStatic#25620SolalPirelli wants to merge 2 commits intoscala:mainfrom
Conversation
Contributor
|
I'm motivated to learn, when I have a few minutes, why it's OK to revert the original code for the phase. I see it was to support the backend. |
Contributor
Author
|
@som-snytt it seems based on git blame that the backend used to emit incorrect code in such cases. I guess this is a classic case of a "temporary" workaround. |
Member
If we suspect that the backend was producing bad code, we should have a |
Contributor
Author
|
i1442 added by the original SelectStatic PR still passes, but it's true it's not the greatest coverage https://github.com/scala/scala3/pull/1445/changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24707
This transform changed
{ x ; y }.vto{ x ; y.v }.But this is not valid if it's within an assignment, e.g.,
{ x ; y }.v = 42becoming the invalid{ x ; y.v } = 42.How much have you relied on LLM-based tools in this contribution?
not
How was the solution tested?
regression test from the issue