chore: use backoff v5 for retryablehttp client#1062
Merged
Conversation
…f maxretry 🔒 Scanned for secrets using gitleaks 8.30.0
fracasula
reviewed
Mar 9, 2026
fracasula
reviewed
Mar 9, 2026
fracasula
reviewed
Mar 9, 2026
fracasula
reviewed
Mar 9, 2026
fracasula
reviewed
Mar 9, 2026
fracasula
reviewed
Mar 9, 2026
1 task
🔒 Scanned for secrets using gitleaks 8.30.0
🔒 Scanned for secrets using gitleaks 8.30.0
atzoum
commented
Mar 9, 2026
| for i := uint(1); i <= c.brokers; i++ { | ||
| bootstrapServers += fmt.Sprintf("PLAINTEXT://kafka%d:9090,", i) | ||
| } | ||
| bootstrapServers := strings.Join(lo.Times(int(c.brokers), func(i int) string { |
Collaborator
Author
There was a problem hiding this comment.
Note: go fix suggested string builder, but this made more sense
🔒 Scanned for secrets using gitleaks 8.30.0
fracasula
approved these changes
Mar 9, 2026
atzoum
changed the title
🔒 Scanned for secrets using gitleaks 8.30.0
mihir20
approved these changes
Mar 10, 2026
itsmihir
reviewed
Mar 10, 2026
🔒 Scanned for secrets using gitleaks 8.30.0
itsmihir
approved these changes
Mar 10, 2026
atzoum
added a commit
to rudderlabs/rudder-server
that referenced
this pull request
Mar 10, 2026
🔒 Scanned for secrets using gitleaks 8.30.0 # Description see rudderlabs/rudder-go-kit#1062 ## Security - [x] The code changed/added as part of this pull request won't create any security issues with how the software is being used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔒 Scanned for secrets using gitleaks 8.30.0
Description
With backoff v4 it was impossible to disable max retries limit, only to set it to max uint64 value. With backoff v5, setting max tries to 0 can actually disable the limit in a clean manner.
Aditional items
Security