Conversation
atzoum
force-pushed
the
fix.retryableHttp
branch
from
20dd525 to
e1fb4d3
Compare
atzoum
commented
Mar 9, 2026
| } | ||
|
|
||
| func newRetryableHTTPClient(baseClient Client, retryableConfig *retryablehttp.Config) Client { | ||
| if retryableConfig == nil { |
Contributor
Author
There was a problem hiding this comment.
Note: never used, always non-nil
🔒 Scanned for secrets using gitleaks 8.30.0
atzoum
force-pushed
the
fix.retryableHttp
branch
from
e1fb4d3 to
2e4d241
Compare
fracasula
approved these changes
Mar 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6754 +/- ##
==========================================
- Coverage 80.08% 79.67% -0.42%
==========================================
Files 565 565
Lines 63374 63373 -1
==========================================
- Hits 50753 50492 -261
- Misses 9619 9889 +270
+ Partials 3002 2992 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🔒 Scanned for secrets using gitleaks 8.30.0
🔒 Scanned for secrets using gitleaks 8.30.0
atzoum
force-pushed
the
fix.retryableHttp
branch
from
a1920ae to
bd097e7
Compare
itsmihir
approved these changes
Mar 10, 2026
🔒 Scanned for secrets using gitleaks 8.30.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔒 Scanned for secrets using gitleaks 8.30.0
Description
see rudderlabs/rudder-go-kit#1062
Security