Open
Conversation
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
Member
|
Thanks for the contribution :) We've marked this PR for discussion in next week's ROS PMC meeting. We should be able to get back to you within the week. |
Member
|
This was discussed in the PMC meeting on 2026-03-24. It was pointed out that support for this keyed topics Zenoh is unknown, plus CycloneDDS for example doesn't appear to support keyed topics. Members wanted to ensure that we do our best not to leak DDS-specific features into the ROS domain, and if we choose to do so that we understand the consequence of our decision to do so! That being said, they weren't opposed to this PR, but they do want to put out a REP to solicit feedback from the wider community. Is this something you'd be willing to lead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add parsing for
@keyinrosidl_adapter.This enables the use of keyed topics with
msg,srvandactionfiles.Fixes #939
Is this user-facing behavior change?
Yes, users can now use keyed topics with
msg,srvandactioninterface files instead ofidl.Did you use Generative AI?
No
Additional Information