Show how custom CM name is working and how CM params don't have to be within yaml.#1028
Open
Show how custom CM name is working and how CM params don't have to be within yaml.#1028
Conversation
github-actions
bot
requested review from
aprotyas,
bijoua29,
bmagyar,
saikishor and
xguay
christophfroehlich
previously approved these changes
Jan 31, 2026
This was referenced Feb 3, 2026
…ing and no overlapping on HW components.
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
destogl
force-pushed
the
hotfix/example2-custom-name-no-overlapping-demo
branch
from
6707d10 to
986f8d3
Compare
christophfroehlich
approved these changes
Feb 4, 2026
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
LGTM, but let's wait until the next sync of kilted + rolling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also is used for testing the fix of the node name overlapping in ros2_control.
Needs ros-controls/ros2_control#3006