fix: Fix PHTCNT, ISPC, and RN header datatypes#747
Open
michaelliangau wants to merge 37 commits intoroman-corgi:developfrom
Open
fix: Fix PHTCNT, ISPC, and RN header datatypes#747michaelliangau wants to merge 37 commits intoroman-corgi:developfrom
michaelliangau wants to merge 37 commits intoroman-corgi:developfrom
Conversation
Update ISPC field across documentation and code to use integer convention (0 or 1) instead of boolean (False or True). ISPC=1 indicates photon counting mode enabled, ISPC=0 indicates analog mode. Changes: - Updated 18 data format documentation files (.rst) - Updated walker.py to check ISPC == 1 instead of ISPC in (True, 1) - Updated test files to use 0/1 instead of False/True - Updated error messages and comments to reflect 0/1 convention Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Change ISPC definition in l1.csv from bool/FALSE to int/0 to match the integer convention used throughout the codebase. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Change ISPC from bool (FALSE) to int (0) to correctly represent photon counting mode as 0 or 1 instead of boolean values. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Resolved conflicts by accepting develop's versions for docs/data_formats and e2e test files. Develop already has the PHTCNT/ISPC int datatype fixes in docs, and the test helper functions have been refactored. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
michaelliangau
commented
Feb 13, 2026
michaelliangau
commented
Feb 13, 2026
Author
|
Feedback from Julia
|
Contributor
|
@michaelliangau can you push your branch to the corgidrp repo (instead of using your forked repo?). It's very clunky for me to run e2e tests for verification from your forked repo. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixing incorrectly specified headers (PHTCNT, ISPC and RN) throughout the pipeline and documentation.
bool→str("True", "False", or "Auto")bool→int(0 or 1)str/int→floatDefault value for PHTCNT is now "Auto".
Additional context
E2E Test Results
All 33 e2e tests passed with v3.3 test data. 28/29
zz_dataformatchecks passed — the one failure (bpmapCTI_CORR/DESMEAR type mismatch) is a pre-existing issue ondevelop, not introduced by this PR.Type of change
Reference any relevant issues (don't forget the #)
#632
Checklist before requesting a review
pytestdid not produce any warnings