fix: Fix PHTCNT, ISPC, and RN header datatypes#753
Closed
michaelliangau wants to merge 1 commit intoroman-corgi:developfrom
Closed
fix: Fix PHTCNT, ISPC, and RN header datatypes#753michaelliangau wants to merge 1 commit intoroman-corgi:developfrom
michaelliangau wants to merge 1 commit intoroman-corgi:developfrom
Conversation
- PHTCNT: bool → str ("True", "False", or "Auto")
- ISPC: bool → int (0 or 1)
- RN: str/int → float
Updates pipeline code, mock data, documentation (.rst files),
header format CSVs, and test files to use correct datatypes.
Resolves #632
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bool→str("True", "False", or "Auto")bool→int(0 or 1)str/int→floatFixes incorrectly specified header datatypes throughout the pipeline, documentation, mock data, and tests.
Reference
Resolves #632
Recreated from #747 with a clean single commit on top of current
develop.Test plan
pytest)🤖 Generated with Claude Code