RI-8275 i18n: migrate Workbench#6189
Open
valkirilov wants to merge 5 commits into
Open
Conversation
Route the Workbench page user-facing strings through i18n under the workbench.* namespace, with Bulgarian translations: - no-results message and Clear Results button - dangerous-command run confirmation (<Trans> with count-based plurals and escaped db-name interpolation) - tutorial titles, view-type labels, Monaco no-index suggestions - document title suffix Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add a Plurals section to the i18n skill: use i18next count-based _one/_other keys (base key type-checks), write the full sentence per form, and delete orphan keys that i18n:extract leaves behind. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Complete the Workbench page translation by routing its shared components through i18n with Bulgarian translations: - components/query/** (editor actions, tutorials, run button, result card header/CLI wrapper, summary plurals) under a new query.* namespace - shared FullScreen control under common.fullScreen.* - resolve tutorial titles and view-type labels at render time via t() instead of module-level i18n.t() (which captured the language at import) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d52dbf5547
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…I-8275) The dangerous-command confirmation renders interpolated values through <Trans> with escapeValue off. `db` was escaped but `commands` (user-typed command text) was not, so markup-like input (e.g. angle brackets) could break out of the <bold> span. Escape `commands` via escapeTrans too, matching the previous literal-text rendering behavior. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Code Coverage - Frontend unit tests
Test suite run success7714 tests passing in 856 suites. Report generated by 🧪jest coverage report action from 00d705e |
The run-query shortcut tooltip label was hardcoded to "Run commands", but the original KEYBOARD_SHORTCUTS label is "Run" on Windows/Linux and "Run commands" on macOS. Restore the platform distinction via isMacOs() with a separate query.runShortcut.labelNonMac key so non-Mac users see the original label. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 00d705e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Route the Workbench page user-facing strings through i18next (
t()/<Trans>), with Bulgarian translations, under theworkbench.*namespace.Testing
yarn type-check(no new errors),yarn i18n:check(en/bg parity),yarn lint:ui.components/queryjest suites pass.?lang=bgto preview Bulgarian; empty bg values fall back to English.Note
Low Risk
Presentation-layer i18n only; behavior of command execution and confirmations is unchanged aside from localized/pluralized copy.
Overview
Routes Workbench and shared query UI copy through i18next (
t(),<Trans>,i18n.t), with matchingen.json/bg.jsonentries underworkbench.*,query.*, andcommon.fullScreen.*.Workbench covers the page title, empty-results panel, tutorial link labels (via
titleKeyin constants), results “clear” actions, Monaco “no indexes” suggestions, and view-type/profile labels from non-React helpers. Shared query components pick up run/clear actions, tooltips, card chrome, CLI warnings, and keyboard shortcut labels (including Mac vs non-Mac).Plurals move to i18next
count+_one/_otherkeys—for example query card summaries and the dangerous-command confirmation inWBViewWrapper(replacing a manualisPluralJSX branch with<Trans count={…}>). The i18n skill doc gains a short Plurals section describing that convention.Tests:
QueryCard.specexpectation updated for the new summary wording.Reviewed by Cursor Bugbot for commit 00d705e. Bugbot is set up for automated code reviews on this repo. Configure here.