RI-8275 i18n: migrate Vector Search#6190
Open
valkirilov wants to merge 3 commits into
Open
Conversation
Route the Vector Search index list area through i18n under vectorSearch.list.* with Bulgarian translations: header + info popover, create-index menu, delete-index confirmation, column headers/tooltips, empty states, and the row-action labels. Column headers/tooltips and row-action labels resolve at render time; a `label` field on IndexListAction keeps `name` stable for test ids. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…I-8275)
Route the Vector Search create-index flow and query page through i18n with
Bulgarian translations.
Create-index flow → vectorSearch.{createIndex,fieldType,onboarding,sampleData,
selectKeyOnboarding}.*: page header/footer/toolbar/content, index-name editor,
confirm-key-change modal, field-type modal + list (labels/tooltips/descriptions/
validation), onboarding, pick-sample-data, select-key onboarding. Shared
field-type descriptions (create-redisearch-index/constants.ts, also used by the
browser make-searchable modal) under vectorSearch.fieldType.desc.*.
Query page → vectorSearch.{query,queryLibrary,commandView}.*: editor actions/
tooltips/tabs/placeholder/Monaco onboarding, query library + save/delete modals,
command view, page header/breadcrumb. Group-command label uses count-based
plurals.
Create-index and query-library toasts go under notification.*. Module-level
constants resolve at render time; Redis tokens left untranslated.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Route the remaining Vector Search screens through i18n with Bulgarian translations, completing pages/vector-search coverage: - welcome screen, no-search-results - index details + info side panel (labels, column headers, tooltips) - RQE-not-available / version-not-supported / upgrade banner / search-page fallback - keys browser (select-key, scan counters, supported-types info) Module-level constants resolve at render time via getters; scan counters use <Trans> to preserve testid spans; Redis type tokens (HASH/JSON) and the document title left untranslated per convention. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0155d39. Configure here.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0155d39f5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Code Coverage - Frontend unit tests
Test suite run success7763 tests passing in 860 suites. Report generated by 🧪jest coverage report action from 0155d39 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Route the entire Vector Search page (
pages/vector-search/**) through i18next with Bulgarian translations, under thevectorSearch.*namespace (list, create-index flow, query page, query library, welcome + state screens).Testing
yarn type-check(no new errors),yarn i18n:check(en/bg parity 665/665),yarn lint:ui.pages/vector-searchjest suite (723 tests) + the browser make-searchable modal suite pass.?lang=bg; empty bg values fall back to English.Note
Low Risk
Large but mechanical string extraction with no auth, data, or API behavior changes; main risk is missing keys or stale module-scope strings if a getter is skipped.
Overview
Adds English and Bulgarian locale entries for the Vector Search experience (
vectorSearch.*) plus related query library / index toasts (notification.*).Vector Search UI no longer uses hardcoded copy: components call
useTranslation,i18n.t, or<Trans>for labels, tooltips, onboarding, modals, and empty states. Shared field-type help text increate-redisearch-index/constants.tsnow referencesdescriptionKeykeys instead of inline English strings (also used outside Vector Search).Runtime getters replace many module-level string tables (column headers, validation messages, onboarding steps, sample-data options, fallback pages) so text follows the active language instead of freezing at import time. Index list row actions can expose a separate
labelwhile keeping stablenameids for tests.Specs that asserted fixed English constants were updated to resolve strings through i18n or the new getters.
Reviewed by Cursor Bugbot for commit 0155d39. Bugbot is set up for automated code reviews on this repo. Configure here.