Merged
Conversation
|
I'd like to see this fixed. It's affecting a project with which I'm involved at work (#775). I suppose I'll have to do some lame workarounds. :-( |
Contributor
|
@philpep Hi Philippe, is this project looking for maintainers/reviewers? Seems like the open PRs are a bit stuck.. |
|
This also applies to |
|
I am affected by this too. I checked the changes and they look fine to me. |
Signed-off-by: Amir Rossert <amir.rossert@safebreach.com>
philpep
force-pushed
the
fix-systemctl-is-active
branch
from
149f42e to
4018bdd
Compare
philpep
approved these changes
Mar 29, 2025
Contributor
philpep
left a comment
philpep
left a comment
There was a problem hiding this comment.
I still think previous behavior (AssertionError) was fine. But I'm also fine with the new proposed behavior. so LGTM.
Contributor
|
Merged, thanks! |
|
Thanks @philpep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for this issue
#748