Adding additional potential systemctl exit status for Ubuntu 24#776
Closed
pfuntner wants to merge 1 commit intopytest-dev:mainfrom
Closed
Adding additional potential systemctl exit status for Ubuntu 24#776pfuntner wants to merge 1 commit intopytest-dev:mainfrom
pfuntner wants to merge 1 commit intopytest-dev:mainfrom
Conversation
Author
|
It looks like the |
Contributor
|
There is already #773, just no reviewers it seems :( |
Author
Oh, great. Thanks, I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple change to
SystemdService.is_running()to allow it to work for Ubuntu 24 to correct the symptoms in #775.On Ubuntu 24,
systemctl is-activate foobar(assumingfoobaris an unknown service) has an exit status of 4 but theis_running()method only expects exit status values of 0, 1, or 3. My change just allows an exit status of 4 as well. The method will returnFalseanyway but it won't raise theAssertionError.I was following
CONTRIBUTING.rstand tried runningtoxfrom a virtual environment on my development machine but it failed and I'm not sure how to fix it. Here's the output: tox output.txt.